Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning button guidance #1999

Closed
wants to merge 1 commit into from
Closed

Add warning button guidance #1999

wants to merge 1 commit into from

Conversation

frankieroberto
Copy link
Contributor

Content re-used from GOVUK Design System.

This can’t be released until nhsuk/nhsuk-frontend#976 has been released.

Resolves #1995

Screenshot

Screenshot showing warning button guidance, with all the content copied from the GOV.UK Design System page

@frankieroberto
Add warning button guidance
4a56e4c 
Content re-used from GOVUK Design System.
@frankieroberto frankieroberto mentioned this pull request Jul 15, 2024
Merged
3 tasks
paulrobertlloyd
paulrobertlloyd approved these changes Jul 15, 2024
View reviewed changes
Copy link

@paulrobertlloyd paulrobertlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frankieroberto!

sarawilcox
sarawilcox reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@sarawilcox sarawilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I've asked Ananda if he can pull it into the review/2-dig-accessibility-fixes branch as that'll be the next release. That way we can share it with people in the staging environment for final approvals.

@frankieroberto
Copy link
Contributor Author

Thanks @sarawilcox! nhsuk/nhsuk-frontend#976 has been merged now (although not yet released). @anandamaryon1 are you ok to pull this into the review branch?

@anandamaryon1
Copy link
Contributor

Thanks @sarawilcox! nhsuk/nhsuk-frontend#976 has been merged now (although not yet released). @anandamaryon1 are you ok to pull this into the review branch?

Done. It'll get reviewed along with the other bits I'm working on, and should be part of the next release.

@anandamaryon1
Copy link
Contributor

Merged in via another branch and now live, thanks @paulrobertlloyd and @frankieroberto

@anandamaryon1 anandamaryon1 deleted the add-warning-button-guidance branch November 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarawilcox sarawilcox sarawilcox left review comments

@paulrobertlloyd paulrobertlloyd paulrobertlloyd approved these changes

@anandamaryon1 anandamaryon1 Awaiting requested review from anandamaryon1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draft design system guidance on warning button variant
4 participants
@frankieroberto @anandamaryon1 @paulrobertlloyd @sarawilcox