Use displayException instead of show
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! If you could fix the CI failures (in this case you probably just need to add some pragmas guarding against old compilers) I think this would be a valuable contribution. |
This is particularly useful in ghc 9.10 and up, where `displayException` shows the attacked annotations, including backtraces (if any).
edsko
force-pushed
the
edsko/displayException
branch
from
e0612ba to
e538a68
Compare
|
Have pushed what's hopefully a fix. This is the first time in my Haskell career I have had CI fail due to a test against hugs, feels like a rite of passage somehow 😬 |
|
Great! Any day now we will support UHC too... |
MaximilianAlgehed
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly useful in ghc 9.10 and up, where
displayExceptionshows the attached annotations, including backtraces (if any).