New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check global is array before reading its values #7

Closed

YKWeyer wants to merge 1 commit into nicwaller:master from YKWeyer:bugfix/exemptusers-typeerror

YKWeyer commented Sep 15, 2022

Using in_array on a null value will return an Exception with PHP8 and later.

<b>Fatal error</b>:  Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /var/www/html/user/plugins/yourls-domainlimit-plugin/plugin.php:28

This MR extends the condition to start by checking the global variable actually is an array before even trying to look for a value in it.


          Check global is array before reading its values

dab89f6

nicwaller mentioned this pull request

Compatibility fixes for PHP 8 and YOURLS 1.9.2 #10

Merged

Owner

nicwaller commented Feb 23, 2024

Thank you for suggesting this fix! It was included with #10 and released as version 1.1.1.

nicwaller closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet