Compatibility fixes for PHP 8 and YOURLS 1.9.2 #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce a few small but essential fixes for compatibility with PHP 8 and YOURLS 1.9.2
YOURLS_USER
is defined before using itdomainlimit_exempt_users
is an array before using it$domainlimit_exempt_users
is not set in config.phpyourls_encodeURI()
yourls_encodeURI
has been deprecated since 1.9.1yourls_escape()
yourls_escape
has been deprecated since 1.7.3yourls_sanitize_url_safe
insteadThis fixes #6
Testing
I added a unit test suite in #11 that gets run with GitHub Actions. The test suite is now passing. ✅
I also completed end-to-end integration testing with these software versions:
Credit
This combines suggested improvements from: