Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated yourls_escape call #8

Closed
wants to merge 1 commit into from
Closed

Replace deprecated yourls_escape call #8

wants to merge 1 commit into from

Conversation

YKWeyer
Copy link

@YKWeyer YKWeyer commented Sep 15, 2022

Fixes #6

yourls_escape has been deprecated since YOURLS 1.7.3, and was always meant to escape values before they are inserted in the database.

As far as I could tell, calling yourls_sanitize_url should be sufficient, since it calls yourls_esc_url, which itself calls yourls_normalize_uri.

yourls_encodeURI is also deprecated since 1.9.1

@nicwaller nicwaller mentioned this pull request Feb 22, 2024
Merged
@nicwaller
Copy link
Owner

Thank you for suggesting this fix! It was included with #10 and released as version 1.1.1.

@nicwaller nicwaller closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with Yourls 1.9
2 participants
@YKWeyer @nicwaller