Skip to content

Commit

Permalink
drop some obviated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelglass committed Jul 18, 2024
1 parent aad39db commit 308a3a7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
7 changes: 0 additions & 7 deletions test-repos/chat-core/src/index.cjs
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
// NOTES:
// default export doesn't behave nicely with CJS
// and need to dip into package path to grab cjs
//
// TODO:
// - stop mixing default & named exports. I guess that will be a breaking change and imply a version bump
// - main in package.json should point to cjs file
const { createConversation } = require("@nlxai/chat-core");

const config = {
Expand Down
5 changes: 0 additions & 5 deletions test-repos/chat-core/src/index.mjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
// NOTES:
// import statements within index.esm.js fail when `type:module` isn't set
//
// TODO:
// - rename index.esm.js to index.mjs
import { createConversation } from "@nlxai/chat-core";

const config = {
Expand Down

0 comments on commit 308a3a7

Please sign in to comment.