Support hosted triggers #111
Conversation
peterszerzo
force-pushed
the
hosted-triggers
branch
from
c8a1162 to
6b21a60
Compare
| */ | ||
| triggers: Triggers; | ||
| triggers?: Triggers; |
There was a problem hiding this comment.
Would it make more sense to pass in an explicit url rather than just null? That also gives them the opportunity to self-host if they so please?
There was a problem hiding this comment.
I think we should check with the broader team whether the custom hosting functionality should be an option (has implications on whether we want to support users with that).
The hosting we will do is automatically configured under those specified URL's at all times, what is optional here is the triggers themselves (mostly for backwards-compatibility), which they can get in a two-liner if they want.
Co-authored-by: Jakub Hampl <[email protected]>
| ? "https://triggers.dev.nlx.ai" | ||
| : "https://triggers.nlx.ai"; |
There was a problem hiding this comment.
It's https://triggers.dev.mm.nlx.ai and https://triggers.mm.nlx.ai
There was a problem hiding this comment.
@vlad31 oh good point, updated!
peterszerzo
force-pushed
the
hosted-triggers
branch
from
e597296 to
3e39d12
Compare
@jakub-nlx also resolves your previous feedback about the
DOMContentLoadedevent being moved inside the SDK method, this will allow the setup script to be a bit simpler.