Add mutation observer #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
peterszerzo
commented
Jun 25, 2024
peterszerzo
commented
- add a mutation observer instance.
- use it to run URL change logic.
- use it to run highlights more efficiently (remove setInterval).
peterszerzo
force-pushed
the
mutation-observer
branch
from
090f5f8 to
e6f6569
Compare
jakub-nlx
reviewed
Jun 25, 2024
peterszerzo
force-pushed
the
mutation-observer
branch
from
dda7ae5 to
dda403f
Compare
peterszerzo
force-pushed
the
mutation-observer
branch
from
5b95209 to
38f6c1f
Compare
jakub-nlx
previously approved these changes
Jun 26, 2024
| * Keeps track of which load steps matched the URL the last time the URL was checked. | ||
| * This does not necessarily mean that the steps in question have actually been triggered (page load events should not fire if subsequent pages also satisfy the URL condition for which a step was already fired). | ||
| */ | ||
| let previouslyMatchedLoadSteps: string[] = []; |
There was a problem hiding this comment.
Perhaps a Set would be better here, since you're doing membership comparisons in a loop?
There was a problem hiding this comment.
Definitely, opened #113 to track.
Co-authored-by: Jakub Hampl <[email protected]>
gampleman
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.