fix journey manager umd #127
Conversation
michaelglass
changed the title
| @@ -65,9 +65,7 @@ export default function buildconfig({ | |||
| commonjs(), // needed to bundle node modules that use cjs | |||
| json(), // needed to fetch package version from package.json | |||
| nodeResolve({ browser: true }), // bundles packages from node_modules | |||
| nodePolyfills({ | |||
| include: "../../node_modules/**/*.js", | |||
There was a problem hiding this comment.
before #119 this value was "../**/node_modules/**/*.js" (presumably taken from ionic-team/rollup-plugin-node-polyfills#17 (comment)).
In 119 I changed it to ../.. to point to the proper node_modules path which may have caused this regression.
I still don't understand why ../**/node_modules is relevant. I believe in the comment linked above, it's for a different monorepo setup where node_modules are symlinked into package directories.
In any case, the change to ../../ broke things. I tried to avoid regressions like this by diffing umd output before and after #119 changes, but apparently that testing was insufficient!
Do you understand what the previous include param was doing? If not I'd rather drop it altogether (like I do in this PR)
michaelglass
changed the title
|
used this html file to test the results of this change In no way a comprehensive test! |
I haven't tested this extensively (across other packagers, for instance) but it appears to at least work for journey manager