make typescript compile #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelglass
force-pushed
the
chat-widget-typescript
branch
from
8582f73 to
017654c
Compare
Merged
|
@michaelglass there is indeed something strange going on here that we should look into, what strikes me off the bat is that the regular Can we move this PR into draft? |
michaelglass
force-pushed
the
chat-widget-typescript
branch
from
017654c to
0145251
Compare
michaelglass
commented
Mar 4, 2024
packages/chat-widget/tsconfig.json
Outdated
| @@ -1,9 +1,10 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es6", | |||
| "module": "esnext", | |||
| "module": "nodenext", | |||
There was a problem hiding this comment.
this is the meat of this change. Unclear to me why targeting esnext won't pull in types.d.ts but it apparently doesn't :-/
michaelglass
force-pushed
the
chat-widget-typescript
branch
from
0145251 to
4f0aa89
Compare
peterszerzo
approved these changes
Mar 4, 2024
peterszerzo
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npx tsc now compiles the chat widget