Expiration check

[peterszerzo]

If the conversation expired since the user interacted with the bot last, reset to a new ID.

[peterszerzo]

Moved to drafts because

sdk/packages/chat-widget/src/index.tsx

Lines 247 to 279 in 7be3c14

	export const retrieveSession = (storeIn: StorageType): SessionData | null => {
	try {
	const storage =
	storeIn === "sessionStorage" ? sessionStorage : localStorage;
	// initial eslint integration
	// eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing
	const data = JSON.parse(storage.getItem(storageKey) || "");
	const responses: Response[] | undefined = data?.responses;
	const conversationId: string | undefined = data?.conversationId;
	// initial eslint integration
	// eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
	if (responses) {
	let expirationTimestamp: number | undefined;
	responses.forEach((response) => {
	// initial eslint integration
	// eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
	if (response.type === "bot" && response.payload.expirationTimestamp) {
	expirationTimestamp = response.payload.expirationTimestamp;
	}
	});
	// initial eslint integration
	// eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
	if (!expirationTimestamp || new Date().getTime() < expirationTimestamp) {
	return { responses, conversationId };
	} else {
	return { responses };
	}
	}
	return null;
	} catch (err) {
	return null;
	}
	};

is already handling this.

[michaelglass]

minor nit (and less precise but)

Suggested change

	return lastExpirationResponse?.type === "bot"
	? lastExpirationResponse.payload.expirationTimestamp
	: undefined;
	return lastExpirationResponse?.payload.expirationTimestamp;

[peterszerzo]

I would rather do more precise and a bit clearer on the data structure.

[michaelglass]

curious how this works for a multimodal when someone is already on the phone. Should this fail hard instead of resetting with a new conversation ID? What's the UX here

[peterszerzo]

This package does not cover multimodal.

[michaelglass]

oh yeah! whoops

[michaelglass]

💭 this seems like it should raise an exception or signal in some way that there's a new conversation starting

[peterszerzo]

@michaelglass totally with you there, we are discussing the behind-the-scenes way to do this, basically any 'your conversation has expired' type of text content needs to be controlled inside the platform, so you can imagine some kind of explicit special message passing will happen here, but later.

[sam-trost]

Can we add a conversationEnded subscription thinger here.

[peterszerzo]

@sam-trost that sounds like a bit of a change in direction, I would rather have a discussion about it at some point this week.

[michaelglass]

the code here looks fine. I'm not sure if it's the right approach.

[peterszerzo]

Abandoning this in favor of #124