#34 (Inventory Upload): Add output to determine inventory upload failure #35
Conversation
jon-nfc
added
the
type::feature
|
G'day @pvcasillasg, As it's pretty late here so I'll review this in the morning. failing CI jobs will need to be fixed. thank you for your contribution. |
pvcasillasg
changed the title
There was a problem hiding this comment.
Thanks again for your contribution. I will appologise for not having the fully repo setup, specifically CONTRIBUTING.md, however #36 has been raised to correct.
RE the failing CI Jobs, As long as the conventional commit jobs are passing then the PR "CI Job" wise is GTG.
Overall only minor styling changes required outside of the conventional commits items.
When complete please re-request review, IF the items from this CR are completed I don't foresee any issues in merging this and cutting a release.
| @@ -103,23 +103,24 @@ | |||
|
|
|||
|
|
|||
| - name: Upload inventory - {{ ansible_hostname }} | |||
There was a problem hiding this comment.
This name belongs to the task not the block.
The block will need a name however, possibly "Capture error and display trace information"
| block: | ||
| - ansible.builtin.uri: |
There was a problem hiding this comment.
| block: | |
| - ansible.builtin.uri: | |
| block: | |
| - ansible.builtin.uri: |
add two blank lines between tasks, begin and end
| {{ nfc_pb_disable_log | default(true) }} | ||
| rescue: |
There was a problem hiding this comment.
| {{ nfc_pb_disable_log | default(true) }} | |
| rescue: | |
| {{ nfc_pb_disable_log | default(true) }} | |
| rescue: |
add two blank lines between tasks, begin and end
| rescue: | ||
| - debug: |
There was a problem hiding this comment.
| rescue: | |
| - debug: | |
| rescue: | |
| - debug: |
add two blank lines between tasks, begin and end
| no_log: > # Contains a secret that logging shows | ||
| {{ nfc_pb_disable_log | default(true) }} | ||
| block: | ||
| - ansible.builtin.uri: |
There was a problem hiding this comment.
task is missing name. return the name that it used to have
| no_log: > # Contains a secret that logging shows | ||
| {{ nfc_pb_disable_log | default(true) }} | ||
| rescue: | ||
| - debug: |
| - 201 | ||
| no_log: > # Contains a secret that logging shows | ||
| {{ nfc_pb_disable_log | default(true) }} | ||
| rescue: |
There was a problem hiding this comment.
Whilst the output will only be shown on error, which meets the intent of #34, the play will now, not fail. you'll need to add a task to ensure the play fails.
| @@ -103,23 +103,24 @@ | |||
|
|
|||
There was a problem hiding this comment.
We use conventional commit format (with footer) for ALL commit messages, please fix your commit message.
within the commits foote close #34.
If not known, since you have a single commit only, you can use git commit --amend to fix the commit message. Then you'll have to use git push --force to update the remote
|
are you going to action this PR? if so when? if not please close it |
Added block to handle errors in responses.