#34 (Inventory Upload): Add output to determine inventory upload failure #35
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -103,23 +103,24 @@ | |||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| - name: Upload inventory - {{ ansible_hostname }} | ||||||||||||||
|
There was a problem hiding this comment. This name belongs to the task not the block. The block will need a name however, possibly "Capture error and display trace information" |
||||||||||||||
| block: | ||||||||||||||
| - ansible.builtin.uri: | ||||||||||||||
|
Comment on lines
+106
to
+107
There was a problem hiding this comment.
Suggested change
add two blank lines between tasks, begin and end There was a problem hiding this comment. task is missing name. return the name that it used to have |
||||||||||||||
| url: "{{ lookup('env', 'ITSM_API') }}/api/device/inventory" | ||||||||||||||
| method: POST | ||||||||||||||
| body_format: json | ||||||||||||||
| src: "/tmp/{{ ansible_hostname }}.json" | ||||||||||||||
| remote_src: true | ||||||||||||||
| headers: | ||||||||||||||
| Authorization: Token {{ lookup('env', 'ITSM_TOKEN') }} | ||||||||||||||
| validate_certs: "{{ lookup('env', 'ITSM_VALIDATE_CERTS') | default(true) | bool }}" | ||||||||||||||
| status_code: | ||||||||||||||
| - 200 | ||||||||||||||
| - 201 | ||||||||||||||
| no_log: > # Contains a secret that logging shows | ||||||||||||||
| {{ nfc_pb_disable_log | default(true) }} | ||||||||||||||
| rescue: | ||||||||||||||
|
Comment on lines
+120
to
+121
There was a problem hiding this comment.
Suggested change
add two blank lines between tasks, begin and end There was a problem hiding this comment. Whilst the output will only be shown on error, which meets the intent of #34, the play will now, not fail. you'll need to add a task to ensure the play fails. |
||||||||||||||
| - debug: | ||||||||||||||
|
Comment on lines
+121
to
+122
There was a problem hiding this comment.
Suggested change
add two blank lines between tasks, begin and end |
||||||||||||||
| msg: "Error uploading inventory: HTTP status {{ result.status }} - {{ result.msg }}" | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| always: | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use conventional commit format (with footer) for ALL commit messages, please fix your commit message.
within the commits foote close #34.
If not known, since you have a single commit only, you can use
git commit --amendto fix the commit message. Then you'll have to usegit push --forceto update the remote