Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit recovery #258

Merged
merged 17 commits into from
Feb 5, 2024
Merged

Deposit recovery #258

merged 17 commits into from
Feb 5, 2024

Conversation

cwlittle
Copy link
Contributor

This PR adds the ability to recover deposits sent to expired signatory sets

@cwlittle cwlittle requested a review from mappum December 20, 2023 22:03
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 243 lines in your changes are missing coverage. Please review.

Comparison is base (843f0e3) 35.21% compared to head (0348aa9) 34.41%.

Files Patch % Lines
src/bitcoin/recovery.rs 0.00% 84 Missing ⚠️
src/bitcoin/relayer.rs 0.00% 72 Missing ⚠️
src/bitcoin/signer.rs 0.00% 56 Missing ⚠️
src/bitcoin/mod.rs 12.90% 27 Missing ⚠️
src/bin/nomic.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    35.21%   34.41%   -0.80%     
===========================================
  Files           24       25       +1     
  Lines         8599     8809     +210     
===========================================
+ Hits          3028     3032       +4     
- Misses        5571     5777     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mappum mappum mentioned this pull request Feb 5, 2024
@mappum mappum merged commit 50f77b4 into develop Feb 5, 2024
9 checks passed
@mappum mappum deleted the deposit-recovery branch February 5, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants