Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the pointcloud_motion_deskew package into the mapper. This is the first step in an effort to move deskewing (and other tasks) outside of the ROS ecosystem, probably inside the mapper. The main motivation behind this intermediate step is to speed the deskewing up or to be able to interpolate motions for more points. The new implementation deskews points only after the input filters are applied, e.g. when we typically discard large portions of the scan with various filters.
Main features included in this PR:
libpointmatcher_ros
. See this PR. Also, you must be on this branch ofnorlab_icp_mapper
for this to work.I realize that in some situations, deskewing the scan after applying the input filters might not be the desired approach. For example, when using voxel sampling, the point for each voxel is selected based on its position, which might afterward change during deskewing. We could eventually treat deskewing as another input filter, but I think this could wait after the integration inside the mapper is finished.