revert CR comment

np-guard · Nov 9, 2023 · 7aa6c93 · 7aa6c93
1 parent 025228f
commit 7aa6c93
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/vpcmodel/semanticDiffSubnets.go b/pkg/vpcmodel/semanticDiffSubnets.go
@@ -131,7 +131,8 @@ func (subnetConfConnectivity *SubnetConfigConnectivity) subtract(other *SubnetCo
 				if otherSrc, ok := other.subnetConnectivity[srcInOther]; ok {
 					if otherConn, ok := otherSrc[dstInOther]; ok {
 						// ToDo: https://github.com/np-guard/vpc-network-config-analyzer/issues/199
-						if conns.Equals(otherConn) {
+						subtractConn := conns.Subtract(otherConn)
+						if subtractConn.IsEmpty() {
 							continue // no diff
 						}
 						connDiff.conn2 = otherConn