124 all subnets grouping #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string so that (among others) grouping can be reused
ShiriMoran
force-pushed
the
124_all_subnets_grouping
branch
from
6db386c to
5ad89a8
Compare
|
solves #124 |
adisos
reviewed
Aug 15, 2023
| sub2-1-ky => sub2-2-ky : All Connections | ||
| sub2-2-ky => sub2-1-ky : All Connections | ||
|
|
||
| connections are stateful unless marked with * |
There was a problem hiding this comment.
we do not yet have any implemented computation of whether subnets connectivity is stateful.
We should remove that comment , and have another issue to handle stateful computation for this as well,
There was a problem hiding this comment.
Opened #138 (next in my todos) as well as ugly WA code that will be removed once the issue is solved
zivnevo
approved these changes
Aug 16, 2023
#141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.