lad regions #548
Draft
lad regions #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robinlovelace
commented
Oct 31, 2024
Robinlovelace
commented
- Update gitignore
- comment-out everything after school routing, for tests
- Testing pattern in targets
- Working dynamic branching (it seems)!
- Dynamic branching for commuting too
- Add garbage_collection
- Try lads as regions
|
The last commit above actually fixes an error and should be ported to main ASAP:
|
|
Hi @wangzhao0217 I think this is the way forward. Advantages of using LADs as regions for build:
There may also be some disadvantages. We will have to make changes to |
wangzhao0217
approved these changes
Nov 1, 2024
|
Any update on this @wangzhao0217 ? I should be able to have a bash later this evening or in the next few days. |
Merged
Robinlovelace
commented
Nov 6, 2024
R/corenet_build_OS.R
Outdated
| @@ -1,11 +1,12 @@ | |||
| corenet_build_OS = function(os_scotland, osm_scotland, la_names) { | |||
|
|
|||
| message("Generate the city's coherent network for each region with growing") | |||
| message("Generate the coherent network for each LA") | |||
R/corenet_build_OS.R
Outdated
|
|
||
| for (la_name in la_names) { | ||
| for (la_name in la_names[2:32]) { |
There was a problem hiding this comment.
👍 testing at scale!
Robinlovelace
commented
Nov 7, 2024
route_ids.csv
Outdated
| @@ -1,4 +1,10 @@ | |||
| nrow,plan,purpose,region,date,id | |||
| 4140,ebike,commute,dumfries_and_galloway,2024-11-31,11332 | |||
| 987,ebike,school,dumfries_and_galloway,NA,11328 | |||
|
Failing for Clackmannshire @wangzhao0217 |
Robinlovelace
commented
Dec 2, 2024
_targets.R
Outdated
Comment on lines
253
to
271
| tar_target(r_commute, | ||
| rs_commute[[1]]$routes, | ||
| pattern = map(rs_commute), | ||
| iteration = "list" | ||
| ), | ||
| tar_target(r_commute_fastest, { | ||
| rs_commute[[1]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_quietest, { | ||
| rs_commute[[3]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_ebike, { | ||
| rs_commute[[4]][[1]]$routes | ||
| }), | ||
| tar_target(r_commute_balanced, { | ||
| rs_commute[[2]][[1]]$routes | ||
| }), |
There was a problem hiding this comment.
This undoes the conciseness benefits of using dynamic branching, right?
wangzhao0217
force-pushed
the
lad-regions
branch
from
59a7eec to
b00c6e6
Compare
Robinlovelace
commented
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.