-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/requirents-extra: add nrfprovision #18457
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2914212554171173d360bd593d669ea0342ecd1c more detailssdk-nrf:
Github labels
List of changed files detected by CI (5)
Outputs:ToolchainVersion: 6d50eb01ac Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Jan and I are looking at this. |
@jangalda-nsc or @thst-nordic Any updates? |
Added requirement of nrfprovision script which is temporary script needed for west ncs-provision script (nRF54L15 KMU provisioning) Signed-off-by: Andrzej Puzdrowski <[email protected]>
Nordic version of pip-compile-cross-platform adds support for propagating extra-index-urls entries to requirements-fixed.txt Signed-off-by: Jan Gałda <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
8d0c32c
to
85d7427
Compare
Fixes issue with pynrfjprog installation Signed-off-by: Jan Gałda <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
2312103
to
e501b9d
Compare
.github/workflows/west-commands.yml
Outdated
@@ -49,6 +49,8 @@ jobs: | |||
- name: Install requirements | |||
shell: bash | |||
run: | | |||
#pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unaddressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it's minor thing, if no more changes needed, we can merge with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
@nrfconnect/ncs-co-build-system Ping. |
Added step for upgrade pip before installing py requirements. Signed-off-by: Andrzej Puzdrowski <[email protected]>
e501b9d
to
2914212
Compare
Added requirement of nrfprovision script which is temporary script needed for west ncs-provision script
(nRF54L15 KMU provisioning)