Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/requirents-extra: add nrfprovision #18457

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

nvlsianpu
Copy link
Contributor

Added requirement of nrfprovision script which is temporary script needed for west ncs-provision script
(nRF54L15 KMU provisioning)

@nvlsianpu nvlsianpu requested review from a team as code owners October 31, 2024 19:18
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 31, 2024
@nvlsianpu nvlsianpu requested a review from thst-nordic October 31, 2024 19:18
@nvlsianpu nvlsianpu added this to the 2.8.0 milestone Oct 31, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 31, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 2914212554171173d360bd593d669ea0342ecd1c

more details

sdk-nrf:

PR head: 2914212554171173d360bd593d669ea0342ecd1c
merge base: 4fff33072bdcc179d3c771e0c37961d4e14df4af
target head (main): 1156b42894b29fb1a73bb30743ebe5c81cbee8a3
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
.github
│  ├── workflows
│  │  ├── oss-history.yml
│  │  ├── validate-pip-requirements-fixed-file.yml
│  │  │ west-commands.yml
scripts
│  ├── requirements-extra.txt
│  │ requirements-fixed.txt

Outputs:

Toolchain

Version: 6d50eb01ac
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6d50eb01ac_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 42
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@thst-nordic
Copy link
Contributor

Jan and I are looking at this.

@nvlsianpu
Copy link
Contributor Author

@jangalda-nsc or @thst-nordic Any updates?

nvlsianpu and others added 2 commits November 5, 2024 10:11
Added requirement of nrfprovision script which is temporary
script needed for west ncs-provision script
(nRF54L15 KMU provisioning)

Signed-off-by: Andrzej Puzdrowski <[email protected]>
Nordic version of pip-compile-cross-platform adds support for
propagating extra-index-urls entries to requirements-fixed.txt

Signed-off-by: Jan Gałda <[email protected]>
Signed-off-by: Andrzej Puzdrowski <[email protected]>
@nvlsianpu nvlsianpu force-pushed the rerquirement-nrfprovision branch from 8d0c32c to 85d7427 Compare November 5, 2024 09:11
Fixes issue with pynrfjprog installation

Signed-off-by: Jan Gałda <[email protected]>
Signed-off-by: Andrzej Puzdrowski <[email protected]>
@nvlsianpu nvlsianpu added the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Nov 5, 2024
@nvlsianpu nvlsianpu force-pushed the rerquirement-nrfprovision branch from 2312103 to e501b9d Compare November 5, 2024 13:43
@@ -49,6 +49,8 @@ jobs:
- name: Install requirements
shell: bash
run: |
#pip install --upgrade pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment can be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unaddressed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's minor thing, if no more changes needed, we can merge with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@nvlsianpu
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system Ping.

Added step for upgrade pip before installing py requirements.

Signed-off-by: Andrzej Puzdrowski <[email protected]>
@nvlsianpu nvlsianpu force-pushed the rerquirement-nrfprovision branch from e501b9d to 2914212 Compare November 6, 2024 09:12
@rlubos rlubos merged commit e7d86bb into nrfconnect:main Nov 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants