Prepare for 3.6.1 release #90
Conversation
ChrisMaddock
force-pushed
the
release/3.6
branch
from
e6986a7 to
d6ae087
Compare
|
Looks good so far. I don't see anything you've missed, but I haven't released this since 3.0 😄 |
CHANGES.md
Outdated
| @@ -0,0 +1,31 @@ | |||
| ### NUnit Xamarin Runner 3.6.0 - January 26, 2017 | |||
There was a problem hiding this comment.
3.6.0 was never released, so this should be changed to the current release 3.6.1 and recently fixed issues added.
build.cake
Outdated
| @@ -12,7 +12,7 @@ var configuration = Argument("configuration", "Release"); | |||
| var isLocal = BuildSystem.IsLocalBuild; | |||
| var isRunningOnAppVeyor = AppVeyor.IsRunningOnAppVeyor; | |||
|
|
|||
| var version = "3.0.1"; | |||
| var version = "3.6.0"; | |||
There was a problem hiding this comment.
I guess you are going to pull in recent changes which will update this to 3.6.1?
| [assembly: AssemblyTrademark("NUnit is a trademark of NUnit Software")] | ||
| [assembly: AssemblyCulture("")] | ||
|
|
||
| [assembly: AssemblyVersion("3.0.*")] | ||
| [assembly: AssemblyFileVersion("3.0.0.0")] | ||
| [assembly: AssemblyVersion("3.6.*")] |
There was a problem hiding this comment.
Should we change this to an explicit version rather than the *?
There was a problem hiding this comment.
Seems sensible to me. I wasn't sure why they were *'s - so I just left them as they were!
|
Thanks for these Rob - I was planning to come back to this PR and update tonight. 🙂 The things I'm currently aware of are:
The nuspec file was done in #85, this branch just needs rebasing. Anything else you can think of? |
|
If, as @rprouse says, we never released 3.6.0, why is this 3.6.1? That seems potentially confusing. |
|
@ChrisMaddock that looks like a good list. @CharliePoole it is going to be 3.6.1 because it is like NUnitLite and references the 3.6.1 framework so we thought they should match to prevent confusion. |
|
I don't think we should use *s in any of our versions. |
ChrisMaddock
force-pushed
the
release/3.6
branch
from
d6ae087 to
53771eb
Compare
Had a spare half hour, so thought I'd get ahead of the game with this.
I think we should still get #75 and #85 into this release - can merge those in and update the release notes once they're done.
Have I missed anything? 😄