-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud7050] iP #532
Open
Cloud7050
wants to merge
123
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
Cloud7050:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Cloud7050] iP #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also edit invalid mark error text
Reuse from Todo parent class via getBasicString()
Also: • Reject unknown commands • Add command aliases • Add TokenManager#getDescription() • Comment assumption and checks expected before using methods • Rename Token#asInt() → toInt()
There are some commented assumptions that could be verified using Java assertions. Let's turn them into Java assertions, and update the Gradle run task to enable assertions. This commit also makes some tweaks to the Gradle config.
Add assertions
Improve code quality
Now that output is no longer to the CLI, where emoji don't really work properly, this feature can be brought back.
This reverts commit e8ad23a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrived Description
This PR is for the purpose of receiving peer reviews and demonstrating knowledge of GFMD. The latter has numerous requirements imposed, therefore, you may find this description to be:
It's a bit like those stereotypical Bollywood films where the editor asks the director how many free transitions they want the movie to have, and the director replies
yes
.So... we use every syntax in the book. Kinda almost.
Now. Let's change topics so fast that you get literary whiplash. Here is how to ping your router on a loop when it starts acting up:
And finally, allow me to end with a totally unrelated quote from 📖 "The Art of Computer Game Design" by Chris Crawford:
I could've just copy-pasted the template, I don't know why I spent so long making this. On the off chance anyone happens by this unremarkable PR... Hope you had a chuckle.