Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud7050] iP #532
base: master
Are you sure you want to change the base?
[Cloud7050] iP #532
Changes from 34 commits
28ad2b8
ed6d4d2
e8b3258
cc7b41d
fb5add2
0b33360
1d9a846
304ec50
2b43d5a
a76b0db
1a28c69
6881b0d
f8ea187
dbc3b33
9be3d20
774a366
21d63d0
0f15682
eddd8a2
4fe1224
e2b528a
35067fb
b88606a
4f1f3f6
5610437
811a80c
e945188
ca81c37
373f286
0e01257
becf338
541f6bc
9a7cdee
59bb19f
e161bc5
abb83ad
ed9c0c6
bc86d2e
c6eed14
8d26682
69f990f
e7c1de2
badd237
f2e99fb
3818dd7
5681260
b7153f7
8308678
c90a50a
bde28cb
09b9691
07914d4
996216e
3befadd
a0fdfd2
3349793
910bca7
4d16a80
8a692b5
3a3d1d2
d0d2b64
1f39294
6b463ae
5df2d8e
735bfd5
0baff58
8e5e69d
929e65c
c9fddc3
1013ed1
6a981f3
e3b0f11
d11ff49
0712206
dd837a3
95daf36
0b5a85f
69c2957
cecdeec
d1ba67a
d8bb3d8
b48a507
6f4c459
b5eaec2
1cd0649
8a65ca9
4cebf4f
3e9daf6
e50e606
3828a89
49cffd0
e42feef
50ec32f
86355bf
54b73ea
fdb9b57
9a50a91
9ec23bd
5acbd95
25d48ee
baf4879
70a2ccf
c00a210
0244d3e
02b1845
4533db1
e2d717a
8fd31e0
6dc36eb
b80e03f
c75c6a4
d72feec
df6551d
59c7896
8fdaaf9
22e50cb
aae82a4
3a6835a
749eba0
e8ad23a
2bb8116
af543d1
b64185d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name does not suit with the return type.
verifyNumber
sounds like it would return aboolean
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. This one is also more of a utility function. I'm a bit apprehensive about starting static methods with
get
since it sounds to me like an instance getter.I named it so because part of its logic involves giving error feedback to the user, but at the end of the call, if the number is valid, then the callee needs to actually use said number (while also knowing whether or not it was valid), thus
@Nullable Integer
instead of justint
.I am open to better name suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come to think of it, if the method were meant to return a boolean, I think it would be called something like
isNumberValid()
. That thought occurred to me when reading this part of the code quality guide: