-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chen1x] iP #744
Open
Chen1x
wants to merge
39
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
Chen1x:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Chen1x] iP #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/jarvis/storage/Storage.java
Program is unable detect if invalid arguments are passed to the methods. Program might crash if invalid arguments are passed to methods unknowingly (e.g. regressions). Let's add assertion statements in each method to make sure the parameters passed in are of expected format. This way regressions and runtime errors are easier identified.
Add A-Assertions
* 'master' of https://github.com/Chen1x/ip: Add A-Assertions
Parser and Storage classes contains Magic Strings Could be confusing to read and find out their purposes Let's assign each of them to a constant with name describing its purpose
Add A-CodeQuality
There is no function for user to figure what deadline is the closest and should be prioritized to be worked on first Let's add a command with input "upcoming" for the chatbot to remind the user about the closest deadline that is not done yet
PS: Why are there sooo many Jarvis bots for IP? We're all unoriginal :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jarvis
Jarvis is pretty useless. It's,
All you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the main method: