-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chen1x] iP #744
Open
Chen1x
wants to merge
39
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
Chen1x:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Chen1x] iP #744
Commits on Aug 8, 2023
-
damithc authored and damithc committed
Aug 8, 2023 Configuration menu - View commit details
-
Copy full SHA for 28ad2b8 - Browse repository at this point
Copy the full SHA 28ad2b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6d4d2 - Browse repository at this point
Copy the full SHA ed6d4d2View commit details
Commits on Aug 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f924607 - Browse repository at this point
Copy the full SHA f924607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5504b - Browse repository at this point
Copy the full SHA 2a5504bView commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 26ba4fe - Browse repository at this point
Copy the full SHA 26ba4feView commit details
Commits on Sep 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f37937e - Browse repository at this point
Copy the full SHA f37937eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34e03ea - Browse repository at this point
Copy the full SHA 34e03eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b82229e - Browse repository at this point
Copy the full SHA b82229eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5488211 - Browse repository at this point
Copy the full SHA 5488211View commit details -
Configuration menu - View commit details
-
Copy full SHA for 605d92f - Browse repository at this point
Copy the full SHA 605d92fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b72726b - Browse repository at this point
Copy the full SHA b72726bView commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7602f41 - Browse repository at this point
Copy the full SHA 7602f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 307f5d3 - Browse repository at this point
Copy the full SHA 307f5d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0f282f - Browse repository at this point
Copy the full SHA c0f282fView commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ebdf08f - Browse repository at this point
Copy the full SHA ebdf08fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 438ca1f - Browse repository at this point
Copy the full SHA 438ca1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e72e54 - Browse repository at this point
Copy the full SHA 6e72e54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c07924 - Browse repository at this point
Copy the full SHA 0c07924View commit details -
Configuration menu - View commit details
-
Copy full SHA for 409fccb - Browse repository at this point
Copy the full SHA 409fccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91eb5f9 - Browse repository at this point
Copy the full SHA 91eb5f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 866c830 - Browse repository at this point
Copy the full SHA 866c830View commit details -
Configuration menu - View commit details
-
Copy full SHA for edc9936 - Browse repository at this point
Copy the full SHA edc9936View commit details -
Merge branch 'branch-A-JavaDoc'
# Conflicts: # src/main/java/jarvis/storage/Storage.java
Configuration menu - View commit details
-
Copy full SHA for 4b08c01 - Browse repository at this point
Copy the full SHA 4b08c01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8120cb9 - Browse repository at this point
Copy the full SHA 8120cb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c56281 - Browse repository at this point
Copy the full SHA 4c56281View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b62744 - Browse repository at this point
Copy the full SHA 9b62744View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d97751 - Browse repository at this point
Copy the full SHA 6d97751View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76674a7 - Browse repository at this point
Copy the full SHA 76674a7View commit details -
Program is unable detect if invalid arguments are passed to the methods. Program might crash if invalid arguments are passed to methods unknowingly (e.g. regressions). Let's add assertion statements in each method to make sure the parameters passed in are of expected format. This way regressions and runtime errors are easier identified.
Configuration menu - View commit details
-
Copy full SHA for ce585b0 - Browse repository at this point
Copy the full SHA ce585b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131064c - Browse repository at this point
Copy the full SHA 131064cView commit details -
Merge branch 'master' of https://github.com/Chen1x/ip
* 'master' of https://github.com/Chen1x/ip: Add A-Assertions
Configuration menu - View commit details
-
Copy full SHA for 02b261a - Browse repository at this point
Copy the full SHA 02b261aView commit details -
Parser and Storage classes contains Magic Strings Could be confusing to read and find out their purposes Let's assign each of them to a constant with name describing its purpose
Configuration menu - View commit details
-
Copy full SHA for 14ec884 - Browse repository at this point
Copy the full SHA 14ec884View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec0d6a5 - Browse repository at this point
Copy the full SHA ec0d6a5View commit details -
Merge pull request #3 from Chen1x/branch-A-CodeQuality
Add A-CodeQuality
Configuration menu - View commit details
-
Copy full SHA for 24c346d - Browse repository at this point
Copy the full SHA 24c346dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a2fbbe - Browse repository at this point
Copy the full SHA 4a2fbbeView commit details -
There is no function for user to figure what deadline is the closest and should be prioritized to be worked on first Let's add a command with input "upcoming" for the chatbot to remind the user about the closest deadline that is not done yet
Configuration menu - View commit details
-
Copy full SHA for 80d307e - Browse repository at this point
Copy the full SHA 80d307eView commit details
Commits on Sep 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5543d56 - Browse repository at this point
Copy the full SHA 5543d56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ac3ae5 - Browse repository at this point
Copy the full SHA 7ac3ae5View commit details -
Improve formatting in User Guide
PS: Why are there sooo many Jarvis bots for IP? We're all unoriginal :(
Configuration menu - View commit details
-
Copy full SHA for 2d23120 - Browse repository at this point
Copy the full SHA 2d23120View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.