Add support for filtering TX lists for method type #1679

csillag · 2025-01-09T03:03:33Z

This PR exposes the runtime tx method search feature added to Nexus in oasisprotocol/nexus#824.

It adds support for filtering runtime TX lists for method type.

Depends on:

storage/consensus: Update indexes to better serve the related accounts queries nexus#890

It also adds the same feature for consensus TX lists, for which the Nexus support has been there for a while.

It works on all consensus and runtime dashboards, transaction list, also including transactions for blocks, accounts and validators.

I suggest reviewing the PR commit by commit, because there are multiple semi-independent small changes.

The account transactions page looks like this:

Or this, when there are no results:

Latest transactions page, on mobile:

For consensus:

github-actions · 2025-01-09T03:03:50Z

Deployed to Cloudflare Pages

Latest commit:	`8ea8fb273aae15cde97777ea13102d1f4096ccca`
Status:	✅ Deploy successful!
Preview URL:	https://2975ecb5.oasis-explorer.pages.dev
Alias:	https://pr-1679.oasis-explorer.pages.dev

csillag · 2025-01-11T01:43:48Z

As discussed with @donouwens, the type filter list for the consensus layer is too long to be convenient. Ideally, it should be replaced with a combo-box with type-ahead search.

However, we plan to support multiple values anyway (later, when nexus will add support for that), so we will replace the widget with a searchable combo-box at that time.

Which means, the current version is as good as it will get, in the current round of implementation.

src/app/components/ConsensusTransactionMethod/index.tsx

src/app/components/Select/index.tsx

lubej · 2025-01-14T11:56:11Z

src/app/components/SubPageCard/index.tsx

+  /**
+   * An optional second title which will be displayed under title / subheader / action
+   */
+  title2?: ReactNode


subtitle maybe?

The problem is that currently we have title, subheader (and action), all displayed in the same row.
If we introduced subtitle, it would be very easy to accidentally confuse it with subheader.

That was my thinking, but I don't have a strong opinion. If you think subtitle would be better, I am open to rename it. What do you think?

In reality this is a workaround to supplement action layouting on mobile. Ideally it should be solved with css instead of misleading abstractions. Maybe a correctly placed flex-wrap would work

src/app/components/Table/index.tsx

lukaw3d

Typescript can make sure these are kept in sync

src/app/components/ConsensusTransactionMethod/index.tsx

csillag · 2025-01-16T12:22:53Z

Please note that filtering for runtime tx type can get some inconsistent results until oasisprotocol/nexus#883 is implemented.

csillag · 2025-01-20T13:01:32Z

This will be greatly improved when oasisprotocol/nexus#890 lands, because it will make it possible to search for the "transfer" type coherently.

src/app/components/ConsensusTransactionMethod/index.tsx

src/app/components/RuntimeTransactionMethod/index.tsx

src/app/components/Select/index.tsx

lukaw3d · 2025-01-22T15:20:28Z

src/app/components/SubPageCard/index.tsx

+  /**
+   * An optional second title which will be displayed under title / subheader / action
+   */
+  title2?: ReactNode


In reality this is a workaround to supplement action layouting on mobile. Ideally it should be solved with css instead of misleading abstractions. Maybe a correctly placed flex-wrap would work

src/app/components/Table/index.tsx

src/app/pages/ConsensusTransactionsPage/index.tsx

Currently, if a <Table> receives zero rows, and it is not loading, it is simply hidden without any trace. This commit introduces the possibility to show a message where the table was supposed to be.

This works on: - the latest transactions page (i.e. /mainnet/sapphire/tx ) - the account transactions page ( /mainnet/sapphire/address/0x683dC5f8cFa3e156b0F695CEa0b8EdeC7322CbF6 ) - block transactions ( /mainnet/consensus/block/22847794 )

(As preparation for filtering for them)

- Add missing methods - Use exhaustedTypeWarning for warning on new, unhandled values, both for labels and icons

csillag force-pushed the csillag/filter-txs-for-method branch from 051268e to 07e7251 Compare January 9, 2025 03:04

csillag marked this pull request as ready for review January 9, 2025 03:04

csillag requested review from lukaw3d, buberdds and lubej as code owners January 9, 2025 03:04

csillag force-pushed the csillag/filter-txs-for-method branch from 0b7e0ce to 4a589e6 Compare January 10, 2025 05:02

csillag mentioned this pull request Jan 10, 2025

[Feature]: Filtering of transactions #1636

Closed

1 task

csillag force-pushed the csillag/filter-txs-for-method branch 8 times, most recently from 6befb60 to e092000 Compare January 11, 2025 01:39

lubej reviewed Jan 14, 2025

View reviewed changes

lukaw3d reviewed Jan 14, 2025

View reviewed changes

src/app/components/ConsensusTransactionMethod/index.tsx Show resolved Hide resolved

src/app/components/ConsensusTransactionMethod/index.tsx Outdated Show resolved Hide resolved

csillag force-pushed the csillag/filter-txs-for-method branch 3 times, most recently from e6dcb06 to 0b41a3c Compare January 15, 2025 03:10

csillag changed the title ~~Add support for filtering latest TX list for method type~~ Add support for filtering TX lists for method type Jan 16, 2025

csillag force-pushed the csillag/filter-txs-for-method branch 2 times, most recently from dc66285 to 5023109 Compare January 16, 2025 11:13

csillag force-pushed the csillag/filter-txs-for-method branch from 5023109 to 28d1944 Compare January 18, 2025 02:51

csillag self-assigned this Jan 18, 2025

csillag force-pushed the csillag/filter-txs-for-method branch from 28d1944 to f1ffc24 Compare January 20, 2025 14:53

csillag mentioned this pull request Jan 21, 2025

Prepare Pontus-X explorer for their MVP #1693

Closed

20 tasks

csillag force-pushed the csillag/filter-txs-for-method branch 6 times, most recently from 93e9d3f to 0f19dd2 Compare January 22, 2025 17:54

lukaw3d reviewed Jan 22, 2025

View reviewed changes

csillag force-pushed the csillag/filter-txs-for-method branch from 7dfabb1 to 9476dfb Compare January 22, 2025 23:27

lukaw3d approved these changes Jan 24, 2025

View reviewed changes

csillag force-pushed the csillag/filter-txs-for-method branch 7 times, most recently from f39783d to d79ea64 Compare January 24, 2025 15:44

csillag added 8 commits January 24, 2025 16:44

Add support for displaying a message instead of empty tables

050e8b1

Currently, if a <Table> receives zero rows, and it is not loading, it is simply hidden without any trace. This commit introduces the possibility to show a message where the table was supposed to be.

LinkableCardLayout: support passing on action

aa52e9c

Implement a light mode for our Select component

41f38ac

Add support for second line of title on SubPageCard

f42f8a6

Refactor how consensus tx type labels are derived

60c7882

(As preparation for filtering for them)

Handle missing consensus tx method names

594d63d

- Add missing methods - Use exhaustedTypeWarning for warning on new, unhandled values, both for labels and icons

Extend transaction method filtering to consensus and validators

8ea8fb2

csillag force-pushed the csillag/filter-txs-for-method branch from d79ea64 to 8ea8fb2 Compare January 24, 2025 15:44

csillag enabled auto-merge January 24, 2025 15:45

csillag merged commit cce5c40 into master Jan 24, 2025
7 checks passed

csillag deleted the csillag/filter-txs-for-method branch January 24, 2025 15:46

csillag mentioned this pull request Jan 29, 2025

[Feature]: Enhance the transaction type filtering feature #1717

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for filtering TX lists for method type #1679

Add support for filtering TX lists for method type #1679

csillag commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

csillag commented Jan 11, 2025

lubej Jan 14, 2025

csillag Jan 14, 2025

lukaw3d Jan 22, 2025

lukaw3d left a comment

csillag commented Jan 16, 2025

csillag commented Jan 20, 2025

lukaw3d Jan 22, 2025

Add support for filtering TX lists for method type #1679

Add support for filtering TX lists for method type #1679

Conversation

csillag commented Jan 9, 2025 • edited Loading

The account transactions page looks like this:

Latest transactions page, on mobile:

For consensus:

github-actions bot commented Jan 9, 2025 • edited Loading

Deployed to Cloudflare Pages

csillag commented Jan 11, 2025

lubej Jan 14, 2025

Choose a reason for hiding this comment

csillag Jan 14, 2025

Choose a reason for hiding this comment

lukaw3d Jan 22, 2025

Choose a reason for hiding this comment

lukaw3d left a comment

Choose a reason for hiding this comment

csillag commented Jan 16, 2025

csillag commented Jan 20, 2025

lukaw3d Jan 22, 2025

Choose a reason for hiding this comment

csillag commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading