Add support for filtering latest TX list for method type #1679
+379
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexus has introduced filtering for tx method in oasisprotocol/nexus#824 Our API wrapper code hasn't yet been updated for this change. This commit selectively updates this single part of the wrapper.
Deployed to Cloudflare Pages
|
Currently, this is only enabled on the latest transactions page (i.e. /mainnet/sapphire/tx )
Currently, if a <Table> receives zero rows, and it is not loading, it is simply hidden. This is not ideal if there are zero rows because of some filtering configured inside the table headers, which is now no longer accessible, since the whole table has been hidden. So this commit introduces an alternative behavior: if we pass an `emptyMessage` to the table, then it will not be hidden even if there are no rows, but instead, the passed message will be displayed. Please note that the default behavior doesn't change; to trigger this new behavior, the new parameter needs to be added.
This can happen when filtering for TX method.
csillag
force-pushed
the
csillag/filter-txs-for-method
branch
from
051268e to
07e7251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the method search feature added to Nexus in oasisprotocol/nexus#824.
It adds support for filtering latest TX list for method type.
Currently, this is only enabled on the latest transactions page (i.e. /mainnet/sapphire/tx )
It looks like this:
Or this, when there are no results: