fabtests/shared.c: Check if fi_info is returned correctly in case of FI_CONNREQ #9355
Conversation
|
Sockets msg ep tests are failing. Would this validation not work for sockets provider? |
|
Hmm... You may need to break apart the if statements and print an error to identify what portion of the check failed. The checks should work for any provider. If sockets is failing, can you identify why? Maybe the provider isn't correct. |
For sockets it looks like the prov_name is NULL and the api versions of info->fabric_attr (0) and fi_pep->fabric_attr (65554) do not match. |
|
That sounds like bugs in the provider. We may need to add a fix to it as part of this PR for the tests to pass. |
|
It does look like the sockets provider is not setting those fields correctly. prov_name is left as NULL. And I think abi_version isn't set either. The good news is that this means the test is working. :) |
…FI_CONNREQ This commit adds validation that the fi_info returned with an FI_CONNREQ event is filled out properly with valid fields. The fi_info should be similar to the fi_info that is used to open passive endpoint. Signed-off-by: Juee Himalbhai Desai <[email protected]>
|
AWS CI failed. |
|
It's a bug in our CI infra code. We will rerun the test after it's fixed. |
|
bot:aws:retest |
1 similar comment
|
bot:aws:retest |
|
Hi @shefty, Please let me know if there are any more comments. |
…truct The api version and provider name returned in fi_info struct are not set correctly in sock_ep.c. Also, info struct is set to fi_dupinfo(hints) to allocate info struct correctly. Signed-off-by: Juee Himalbhai Desai <[email protected]>
|
Intel CI error is unrelated to this change. |
|
thanks! |
This commit adds validation that the fi_info returned with an FI_CONNREQ
event is filled out properly with valid fields. The fi_info should be
similar to the fi_info that is used to open passive endpoint.