-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimenting with Microfrontends #9194
Open
gigincg
wants to merge
22
commits into
develop
Choose a base branch
from
microfrontend
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1637e00
WIP Microfrontends; Add few shadcn components
gigincg 2918119
Merge branch 'develop' into microfrontend
gigincg c910111
Cleanup Meta field
gigincg 4497313
Merge develop into microfrontend
gigincg b0b0880
Solve Compilation Issues
gigincg 4ebd325
WIP: Microfrontends without Shared Deps
gigincg 92f24fd
PoC: Dynamic Loaded Microfrontends with Dynamic import
gigincg 4d5fae7
Experimenting with Builds
gigincg 20754eb
Merge branch 'develop' into microfrontend
gigincg 94c8217
Disable Deps sharing
gigincg efbf43c
Configure rollup as platform-deps
gigincg ca3e118
Switch out of SWC
gigincg 9b982c1
Revert to pre-mf config
gigincg dbc9443
Fix Microfrontend URL; Update build command
gigincg cba055f
Reinclude the setup script for the sake of the pluginMap
gigincg 2bf352e
Add optional deps for rollup
gigincg dd1cdf9
add postinstall
gigincg 5900873
Reconfigure platform deps script
gigincg 29ba23c
Switch Microfrontend url to https
gigincg d94bd4d
Share: Plausible, hooks, icons
gigincg ae364be
Few more shared components
gigincg 79e2910
Merge branch 'develop' into microfrontend
gigincg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
API documentation needs type safety improvements
The API route definition example could be enhanced:
Type<ScribeModel>()
syntax seems non-standardroutes
object structureConsider updating to: