Revert "[GLT-3976] added copy buttons for donor names and external na…

…mes (#153)" This reverts commit 0bca60c.
oicr-gsi · Sep 12, 2023 · 6fca3f5 · 6fca3f5
1 parent 0bca60c
commit 6fca3f5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 34 deletions.
diff --git a/changes/add_copyName-donor b/changes/add_copyName-donor
diff --git a/ts/data/case.ts b/ts/data/case.ts
@@ -21,7 +21,6 @@ import {
 } from "./requisition";
 import { Tooltip } from "../component/tooltip";
 import { caseFilters, latestActivitySort } from "../component/table-components";
-import { makeCopyButton } from "../util/html-utils";
 
 const dayMillis = 1000 * 60 * 60 * 24;
 
@@ -131,20 +130,16 @@ export const caseDefinition: TableDefinition<Case, Test> = {
       title: "Donor",
       sortType: "text",
       addParentContents(kase, fragment) {
-        const nameDiv = makeNameDiv(
-          kase.donor.name,
-          urls.miso.sample(kase.donor.id),
-          urls.dimsum.donor(kase.donor.name),
-          kase.donor.name
+        fragment.appendChild(
+          makeNameDiv(
+            kase.donor.name,
+            urls.miso.sample(kase.donor.id),
+            urls.dimsum.donor(kase.donor.name)
+          )
         );
-        fragment.appendChild(nameDiv);
-
-        const externalNameDiv = makeTextDivWithTooltip(
-          kase.donor.externalName,
-          "External Name",
-          true
+        fragment.appendChild(
+          makeTextDivWithTooltip(kase.donor.externalName, "External Name")
         );
-        fragment.appendChild(externalNameDiv);
 
         const tumourDetailDiv = document.createElement("div");
         tumourDetailDiv.appendChild(

diff --git a/ts/util/html-utils.ts b/ts/util/html-utils.ts
@@ -157,30 +157,13 @@ export function makeCopyButton(text: string): HTMLButtonElement {
   return button;
 }
 
-export function makeTextDivWithTooltip(
-  text: string,
-  tooltip: string,
-  addCopyButton = false
-) {
+export function makeTextDivWithTooltip(text: string, tooltip: string) {
   const div = document.createElement("div");
-  div.className = "flex flex-row space-x-1 items-center";
-  const textSpan = document.createElement("span");
-  textSpan.appendChild(document.createTextNode(text));
-
-  if (addCopyButton) {
-    const copyButton = makeCopyButton(text);
-    copyButton.classList.add("text-12");
-    div.appendChild(textSpan);
-    div.appendChild(copyButton);
-  } else {
-    div.appendChild(textSpan);
-  }
-
+  div.appendChild(document.createTextNode(text));
   const tooltipInstance = Tooltip.getInstance();
   const addContents = (fragment: DocumentFragment) =>
     fragment.appendChild(document.createTextNode(tooltip));
-  tooltipInstance.addTarget(textSpan, addContents);
-
+  tooltipInstance.addTarget(div, addContents);
   return div;
 }