more fixups

oicr-gsi · Jan 23, 2024 · d2c296b · d2c296b
1 parent dbb117f
commit d2c296b
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/main/java/ca/on/oicr/gsi/dimsum/service/filtering/PendingState.java b/src/main/java/ca/on/oicr/gsi/dimsum/service/filtering/PendingState.java
@@ -338,7 +338,7 @@ protected Function<Case, Stream<Sample>> getFilteredSamples(MetricCategory reque
     throw new IllegalStateException("This gate does not apply to samples");
   }
 
-  public static class Helpers {
+  private static class Helpers {
     public static String TOP_UP_REASON = "Top-up Required";
     public static Predicate<Sample> pendingQc = Helpers::isPendingQc;
     public static Predicate<Sample> pendingDataReview = Helpers::isPendingDataReview;
@@ -351,7 +351,7 @@ public static class Helpers {
         kase -> kase.getReceipts().stream().anyMatch(passed)
             && kase.getReceipts().stream().noneMatch(pendingQc);
 
-    public static boolean isPassed(Sample sample) {
+    private static boolean isPassed(Sample sample) {
       return isTrue(sample.getQcPassed())
           && (sample.getRun() == null || isTrue(sample.getDataReviewPassed()));
     }
@@ -360,20 +360,20 @@ private static boolean isTrue(Boolean value) {
       return Boolean.TRUE.equals(value);
     }
 
-    public static boolean isPendingQc(Sample sample) {
+    private static boolean isPendingQc(Sample sample) {
       return sample.getQcPassed() == null && !isTopUpRequired(sample);
     }
 
     private static boolean isPendingReceiptQc(Case kase) {
       return kase.getReceipts().stream().anyMatch(pendingQc);
     }
 
-    public static boolean isPendingDataReview(Sample sample) {
+    private static boolean isPendingDataReview(Sample sample) {
       return sample.getQcUser() != null && sample.getRun() != null
           && sample.getDataReviewPassed() == null;
     }
 
-    public static boolean isTopUpRequired(Sample sample) {
+    private static boolean isTopUpRequired(Sample sample) {
       return TOP_UP_REASON.equals(sample.getQcReason());
     }