Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLT-3987] Removed QC report button from requisition details #155

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

wuall826
Copy link
Contributor

Jira ticket or GitHub issue: https://jira.oicr.on.ca/browse/GLT-3987

✅ Includes a change file

Copy link
Collaborator

@djcooke djcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is deleting change files from other PRs?

ts/details.ts Outdated Show resolved Hide resolved
changes/remove_qcReportButton Outdated Show resolved Hide resolved
@wuall826
Copy link
Contributor Author

wuall826 commented Sep 19, 2023

This PR is deleting change files from other PRs?

I think it might be because I used the repository before the new dimsum release, so it contained the change file from other PRs commits.

@wuall826 wuall826 force-pushed the GLT-3987_removeButton branch from 0556b1d to b66be30 Compare September 19, 2023 13:48
@callunity
Copy link
Contributor

This PR is deleting change files from other PRs?

I think it might be because I used the repository before the new dimsum release, so it contained the change file from other PRs commits.

A rebase on the current state of main should update this.

@wuall826 wuall826 force-pushed the GLT-3987_removeButton branch from b66be30 to 344fc57 Compare September 22, 2023 18:11
@wuall826
Copy link
Contributor Author

Don't mind this commit I think something's wrong

@wuall826 wuall826 force-pushed the GLT-3987_removeButton branch from 344fc57 to 4c68218 Compare September 22, 2023 18:53
@wuall826 wuall826 merged commit cf6e1dd into main Sep 25, 2023
@wuall826 wuall826 deleted the GLT-3987_removeButton branch September 25, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants