[GP-4352] Standard Output Logger plugin #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: GP-4352
If no plugin with logging (ie, only Loki at this time) is configured, logs written out through the Definer are simply lost.
The PluginManager cannot have enough insight into the plugins in order to determine whether one of the plugins actually does anything with the log lines, so the PluginManager cannot itself provide a stdout fallback.
Implements a stdout logging plugin for use in local development scenarios where you do not want to connect your local shesmu to loki and pollute the logs there.
Also fixes a compilation problem on master.