Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gp 4415.add cardea detailed case input format #1331

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

grapigeau
Copy link
Contributor

JIRA Ticket: https://jira.oicr.on.ca/browse/GP-4415

  • Updates Changelog
  • Updates developer documentation

@avarsava
Copy link
Contributor

Detailed summaries seem to differ from the original summaries by three columns - why not expand the existing format?

@grapigeau
Copy link
Contributor Author

grapigeau commented Oct 16, 2024

Detailed summaries seem to differ from the original summaries by three columns - why not expand the existing format?

The eventual goal is to deprecate and replace the existing case_summary but the understanding is this will not be an instant transition.

The meeting notes linked in the ticket give a little more info: https://wiki.oicr.on.ca/display/GSI/Review+of+New+Case+Format+for+Shesmu

@avarsava
Copy link
Contributor

If none of the columns in use in the case_summary format are changing, then adding new columns to the format won't affect production olives at all. I'm not sure I understand the concern

@grapigeau
Copy link
Contributor Author

If none of the columns in use in the case_summary format are changing, then adding new columns to the format won't affect production olives at all. I'm not sure I understand the concern

We decided not to include limsIds (list) in Cardea since it's duplicate information so it's not just an addition of columns.

@avarsava
Copy link
Contributor

What do you mean by limsIds not being in cardea? Where do they come from then?

@grapigeau
Copy link
Contributor Author

grapigeau commented Oct 17, 2024

What do you mean by limsIds not being in cardea? Where do they come from then?

I mean the value "limsIds": [ "string" ] which is present at the /shesmu-cases endpoint is not available at the /shesmu-detailed-cases endpoint. I should've specified new Cardea endpoint, not "Cardea."

@mlaszloffy
Copy link
Contributor

Detailed summaries seem to differ from the original summaries by three columns - why not expand the existing format?

caseStatus logic is also changing.

@grapigeau grapigeau merged commit ef0321c into master Oct 22, 2024
12 checks passed
@grapigeau grapigeau deleted the GP-4415.add_cardea_detailed_case_input_format branch October 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants