Add timeouts to SSH refillers #1338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force all SSH refillers to be run through the `timeout` command to limit their runtime. This also moves the provided checksum from a command line argument to an environment variable.
avarsava
approved these changes
Nov 29, 2024
| seconds can be specified for the runtime of a refiller. If specified, | ||
| `"timeout"` can be set for each refiller, or the top-level `"refillerTimeout"` | ||
| can set the default if none is specified per refiller. If both are absent or | ||
| `null` a default of 38 minutes is used. This is implemented using the `timeout` |
There was a problem hiding this comment.
It's the maximum amount of time you can keep a Stargate connected unless you're near a blackhole.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force all SSH refillers to be run through the
timeoutcommand to limit their runtime. This also moves the provided checksum from a command line argument to an environment variable.JIRA Ticket: