Train the trainer #236

pwalczysko · 2022-11-01T16:02:38Z

This PR adds a walkthrough for enabling of users to prepare trainings on OMERO.

The chapter added here is:

Prepare a training on OMERO (training.rst)

cc @jburel @joshmoore

The installation bits were moved to ome/omero-documentation#2291

Built on https://omero-guides--236.org.readthedocs.build/en/236/

index.rst

training.rst

jburel · 2022-12-09T12:40:58Z

Apologies I reviewed that PR a while back and forgot to submit the pending comment/suggestions

Co-authored-by: jean-marie burel <[email protected]>

pwalczysko · 2022-12-09T16:51:52Z

I think this is ready for a review.

install.rst

jburel · 2022-12-09T17:36:11Z

install.rst

+Install a server
+----------------
+
+Get an empty box or virtual machine with CentOS 7.


Still empty box
Maybe indicate that the installation steps described below have been tested on CentOS 7 only.
Someone may want to install on Ubuntu20.04 for example

Thanks, this is because the install.rst is actually not supposed to be added in this PR. But snoopy was constantly reporting conflicts with #232 so I rebased that PR on top of the PR here. I will remove the install.rst ?

Fixed it also here in 1f7e120 - I also accepted all the other changes in the install.rst - maybe I can close the other PR and continue working just here on one PR only

training.rst

jburel · 2022-12-09T17:46:48Z

training.rst

+
+You also have the option to follow the server installation steps in the `sysadmin documentation <https://omero.readthedocs.io/en/stable/sysadmins/unix/server-installation.html>`_. In this case, you will have to install `Apps for OMERO.web <https://www.openmicroscopy.org/omero/apps/>`_ in separate, post installation steps. We recommend to install all apps listed on the webpage except OMERO.gallery and OMERO.mapr. 
+
+In case any other installation method was used than `training ansible playbook <https://github.com/ome/prod-playbooks/blob/master/omero/training-server/playbook.yml>`_, you have to also set up the server configuration according to the `configuration block in the playbook <https://github.com/ome/prod-playbooks/blob/c72014f7f5a181d4d4daad3b86045f1c4e41a75b/omero/training-server/playbook.yml#L473>`_.


Suggested change

In case any other installation method was used than `training ansible playbook <https://github.com/ome/prod-playbooks/blob/master/omero/training-server/playbook.yml>`_, you have to also set up the server configuration according to the `configuration block in the playbook <https://github.com/ome/prod-playbooks/blob/c72014f7f5a181d4d4daad3b86045f1c4e41a75b/omero/training-server/playbook.yml#L473>`_.

In case any other installation method was used than `training ansible playbook <https://github.com/ome/prod-playbooks/blob/master/omero/training-server/playbook.yml>`_, you have to also set up the server configuration according to the `configuration block in the playbook <https://github.com/ome/prod-playbooks/blob/master/omero/training-server/playbook.yml#L47>`_.

@jburel You don't like the commit there? Are you happy to assume that line 473 (changed to 47) will always be the correct line?

This whole block was removed, so the line number is not relevant now.. The philosophical question though remains: link to master or to commits ? Maybe this is related to the fact that some repos do not have frequent releases, e.g. prod-playbooks ?

training.rst

Co-authored-by: jean-marie burel <[email protected]>

joshmoore · 2023-01-24T09:51:49Z

I've definitely lost track a bit, so a quick question: is this still the only location that documents an ansible installation? If so, I worry about that. Otherwise, big 👍 for the training-the-trainers guide.

pwalczysko · 2023-01-24T09:55:00Z

I've definitely lost track a bit, so a quick question: is this still the only location that documents an ansible installation? If so, I worry about that. Otherwise, big 👍 for the training-the-trainers guide.

Yes, it is the only one. How to alleviate your worry ?

joshmoore · 2023-01-24T09:57:23Z

What is the plan on documenting it elsewhere? Sorry, I can no longer find my previous comment to this point. My memory is that I brought it up and the answer was roughly, "I'm drafting it here then we'll discuss".

pwalczysko · 2023-01-24T10:37:11Z

What is the plan on documenting it elsewhere? Sorry, I can no longer find my previous comment to this point. My memory is that I brought it up and the answer was roughly, "I'm drafting it here then we'll discuss".

I'm drafting it here then we'll discuss - I guess yes, this is what I said, and this is what happened. I have drafted it here (here == this PR, I never meant to draft anything else, as this would need a discussion), and we should discuss now imho :) - sorry if I missed something, I will try to find the older comments...

pwalczysko · 2023-01-24T10:51:33Z

@joshmoore the discussion is #232 (comment) and ends with #232 (comment). Almost certainly there will be differences in understanding those comments, this is why I suggested a discussion in #236 (comment)

pwalczysko · 2023-01-25T16:17:51Z

@jburel @joshmoore adjusted as per discussion this morning, thank you

training.rst

pwalczysko · 2023-01-25T18:30:15Z

Thanks @will-moore , fixes pushed

pwalczysko · 2023-01-25T20:15:13Z

All: Thanks again, I have pushed the changes and retested all scripts now, ready for review.

cc @will-moore @jburel @joshmoore

will-moore

just minor suggestions....

training.rst

pwalczysko · 2023-01-27T14:44:39Z

Thank you @will-moore , fixes pushed.

will-moore

Changes look good, thanks

pwalczysko · 2023-02-02T13:17:10Z

Any objections to me merging this now @jburel @joshmoore please ?

jburel · 2023-02-02T14:36:12Z

Thanks for migrating the "ansible" section.
It looks good now

joshmoore · 2023-02-02T15:12:14Z

Sorry, my 👍 from #236 (comment) meant no objections. Thanks, @pwalczysko!

pwalczysko · 2023-02-02T15:13:53Z

@joshmoore No problem, thanks all, merging.

pwalczysko force-pushed the train-the-t branch 2 times, most recently from 6989175 to 1b063f2 Compare December 9, 2022 12:06

Add train-the-trainer rst

d895d9e

pwalczysko force-pushed the train-the-t branch from 1b063f2 to d895d9e Compare December 9, 2022 12:10

pwalczysko mentioned this pull request Dec 9, 2022

WiP: Install omero #232

Closed

jburel reviewed Dec 9, 2022

View reviewed changes

pwalczysko and others added 6 commits December 9, 2022 13:56

Update training.rst

b6769d8

Co-authored-by: jean-marie burel <[email protected]>

Add installation workflow

5268a7c

Adjust the "empty box" sentence cf. J-M's comment

a67fecc

Update training.rst

1b3df50

Co-authored-by: jean-marie burel <[email protected]>

Update training.rst

3f65e2c

Co-authored-by: jean-marie burel <[email protected]>

Add cleanup scripts

8173661

ome deleted a comment from snoopycrimecop Dec 9, 2022

pwalczysko requested a review from jburel December 9, 2022 16:51

jburel reviewed Dec 9, 2022

View reviewed changes

pwalczysko and others added 9 commits December 12, 2022 11:18

Update install.rst

e60d955

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

2d51a54

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

b536b8a

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

1d4353d

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

b4b9672

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

a912089

Co-authored-by: jean-marie burel <[email protected]>

Update training.rst

0dda5a2

Co-authored-by: jean-marie burel <[email protected]>

Update training.rst

dc8fcf9

Co-authored-by: jean-marie burel <[email protected]>

Update install.rst

6bffc61

Co-authored-by: jean-marie burel <[email protected]>

pwalczysko mentioned this pull request Jan 25, 2023

Add ansible and docker install doc - former "install.rst" ome/omero-documentation#2291

Open

pwalczysko added 2 commits January 25, 2023 15:05

Remove install.rst

0bd9843

Remove references to install, more precise formulations

8b8b948

will-moore reviewed Jan 25, 2023

View reviewed changes

training.rst Show resolved Hide resolved

will-moore reviewed Jan 25, 2023

View reviewed changes

training.rst Outdated Show resolved Hide resolved

will-moore reviewed Jan 25, 2023

View reviewed changes

training.rst Show resolved Hide resolved

will-moore reviewed Jan 25, 2023

View reviewed changes

training.rst Outdated Show resolved Hide resolved

Fixes cf. Will's comments

6852228

pwalczysko added 2 commits January 25, 2023 18:35

Fix error found when testing scripts

2052c09

More corrections from scripts testing

87011e8

pwalczysko requested a review from will-moore January 25, 2023 20:15

will-moore reviewed Jan 27, 2023

View reviewed changes

training.rst Outdated Show resolved Hide resolved

training.rst Outdated Show resolved Hide resolved

training.rst Show resolved Hide resolved

training.rst Outdated Show resolved Hide resolved

training.rst Outdated Show resolved Hide resolved

training.rst Show resolved Hide resolved

Adjust cf. Will's comments

ea7d1e2

pwalczysko requested a review from will-moore January 27, 2023 14:46

will-moore approved these changes Jan 27, 2023

View reviewed changes

pwalczysko merged commit e48edaa into ome:master Feb 2, 2023

pwalczysko deleted the train-the-t branch February 2, 2023 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Train the trainer #236

Train the trainer #236

pwalczysko commented Nov 1, 2022 •

edited

Loading

jburel commented Dec 9, 2022

pwalczysko commented Dec 9, 2022

jburel Dec 9, 2022

pwalczysko Dec 12, 2022

pwalczysko Dec 12, 2022

jburel Dec 9, 2022

will-moore Jan 27, 2023

pwalczysko Jan 27, 2023

joshmoore commented Jan 24, 2023

pwalczysko commented Jan 24, 2023

joshmoore commented Jan 24, 2023 •

edited

Loading

pwalczysko commented Jan 24, 2023

pwalczysko commented Jan 24, 2023

pwalczysko commented Jan 25, 2023

pwalczysko commented Jan 25, 2023

pwalczysko commented Jan 25, 2023

will-moore left a comment

pwalczysko commented Jan 27, 2023

will-moore left a comment

pwalczysko commented Feb 2, 2023

jburel commented Feb 2, 2023

joshmoore commented Feb 2, 2023

pwalczysko commented Feb 2, 2023


		You also have the option to follow the server installation steps in the `sysadmin documentation <https://omero.readthedocs.io/en/stable/sysadmins/unix/server-installation.html>`_. In this case, you will have to install `Apps for OMERO.web <https://www.openmicroscopy.org/omero/apps/>`_ in separate, post installation steps. We recommend to install all apps listed on the webpage except OMERO.gallery and OMERO.mapr.

		In case any other installation method was used than `training ansible playbook <https://github.com/ome/prod-playbooks/blob/master/omero/training-server/playbook.yml>`_, you have to also set up the server configuration according to the `configuration block in the playbook <https://github.com/ome/prod-playbooks/blob/c72014f7f5a181d4d4daad3b86045f1c4e41a75b/omero/training-server/playbook.yml#L473>`_.

Train the trainer #236

Train the trainer #236

Conversation

pwalczysko commented Nov 1, 2022 • edited Loading

jburel commented Dec 9, 2022

pwalczysko commented Dec 9, 2022

jburel Dec 9, 2022

Choose a reason for hiding this comment

pwalczysko Dec 12, 2022

Choose a reason for hiding this comment

pwalczysko Dec 12, 2022

Choose a reason for hiding this comment

jburel Dec 9, 2022

Choose a reason for hiding this comment

will-moore Jan 27, 2023

Choose a reason for hiding this comment

pwalczysko Jan 27, 2023

Choose a reason for hiding this comment

joshmoore commented Jan 24, 2023

pwalczysko commented Jan 24, 2023

joshmoore commented Jan 24, 2023 • edited Loading

pwalczysko commented Jan 24, 2023

pwalczysko commented Jan 24, 2023

pwalczysko commented Jan 25, 2023

pwalczysko commented Jan 25, 2023

pwalczysko commented Jan 25, 2023

will-moore left a comment

Choose a reason for hiding this comment

pwalczysko commented Jan 27, 2023

will-moore left a comment

Choose a reason for hiding this comment

pwalczysko commented Feb 2, 2023

jburel commented Feb 2, 2023

joshmoore commented Feb 2, 2023

pwalczysko commented Feb 2, 2023

pwalczysko commented Nov 1, 2022 •

edited

Loading

joshmoore commented Jan 24, 2023 •

edited

Loading