Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests for v2 command buffer #2670

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Enable tests for v2 command buffer #2670

wants to merge 5 commits into from

Conversation

Xewar313
Copy link
Contributor

@Xewar313 Xewar313 commented Feb 7, 2025

This PR enables conformance tests to work with v2 command buffer implementation. Unfortunately, some tests fail, due to the fact that respective functions are not implemented.

@Xewar313 Xewar313 requested a review from a team as a code owner February 7, 2025 09:48
@github-actions github-actions bot added conformance Conformance test suite issues. level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Feb 7, 2025
pbalcer
pbalcer reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep UUR_KNOWN_FAILURE_ON on tests that we know are failing ;) That's what it's for.

This was referenced Feb 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC left review comments

@pbalcer pbalcer pbalcer approved these changes

@lslusarczyk lslusarczyk lslusarczyk left review comments

@konradkusiak97 konradkusiak97 konradkusiak97 approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. level-zero L0 adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xewar313 @EwanC @pbalcer @konradkusiak97 @lslusarczyk