Make command-buffer creation descriptor mandatory #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
EwanC
force-pushed
the
ewan/command-buffer_desc
branch
2 times, most recently
from
12e0e79 to
78d089c
Compare
EwanC
added a commit
to EwanC/llvm
that referenced
this pull request
Feb 10, 2025
Bumps to UR tag to pull in UR change from oneapi-src/unified-runtime#2676 No DPC++ changes are required as `graph_impl.cpp` already unconditionally passes a descriptor on UR command-buffer creation.
pbalcer
approved these changes
Feb 10, 2025
fabiomestre
approved these changes
Feb 12, 2025
EwanC
force-pushed
the
ewan/command-buffer_desc
branch
from
78d089c to
e23d115
Compare
EwanC
added a commit
to EwanC/llvm
that referenced
this pull request
Feb 12, 2025
Bumps to UR tag to pull in UR change from oneapi-src/unified-runtime#2676 No DPC++ changes are required as `graph_impl.cpp` already unconditionally passes a descriptor on UR command-buffer creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2670 (comment) the
pCommandBufferDescparameter tourCommandBufferCreateExpis optional. However, the UR spec doesn't state what the configuration of the created command-buffer is when this isn't passed, and being optional is also inconsistent with the description parameters to urSamplerCreate & urMemImageCreate which are not optional. This PR updates the descriptor parameter to command-buffer creation to be mandatory to address these concerns.Closes #2673
DPC++ PR intel/llvm#16937