Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-cur): add error handling for CostReport construct outside us-east-1 #24

Merged
merged 6 commits into from
May 4, 2024
Merged

feat(aws-cur): add error handling for CostReport construct outside us-east-1 #24

merged 6 commits into from
May 4, 2024

Conversation

tomoki10
Copy link
Contributor

@tomoki10 tomoki10 commented May 4, 2024

Fixed: #23

  • Run unit tests (npx projen test)
  • Run integration tests (npx projen integ:update; npx projen integ)

@tomoki10 tomoki10 changed the title feat(aws-cur): Add error handling when CUR is running outside the us-east-1 region feat(aws-cur): add error handling for CUR outside us-east-1 May 4, 2024
go-to-k
go-to-k requested changes May 4, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I made only minor comments.

src/aws-cur/README.md Show resolved Hide resolved
src/aws-cur/cost-report.ts Outdated Show resolved Hide resolved
test/aws-cur/cost-report.test.ts Outdated Show resolved Hide resolved
@tomoki10 tomoki10 requested a review from go-to-k May 4, 2024 10:50
go-to-k
go-to-k approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! I'll approve and merge.

@go-to-k go-to-k changed the title feat(aws-cur): add error handling for CUR outside us-east-1 feat(cur): add error handling for CUR outside us-east-1 May 4, 2024
@go-to-k go-to-k changed the title feat(cur): add error handling for CUR outside us-east-1 feat(cur): add error handling for CostReport construct outside us-east-1 May 4, 2024
@go-to-k go-to-k changed the title feat(cur): add error handling for CostReport construct outside us-east-1 feat(cur): add error handling for CostReport construct outside us-east-1 May 4, 2024
@go-to-k go-to-k added this pull request to the merge queue May 4, 2024
Merged via the queue into open-constructs:main with commit cf66ca3 May 4, 2024
5 checks passed
@tomoki10 tomoki10 deleted the feat/cur-use-only-us-east-1 branch May 4, 2024 11:03
@hoegertn
Copy link
Contributor

hoegertn commented May 4, 2024

Small comment: please use aws-cur for the scope of PR titles next time.

@tomoki10 tomoki10 changed the title feat(cur): add error handling for CostReport construct outside us-east-1 feat(aws-cur): add error handling for CostReport construct outside us-east-1 May 5, 2024
This was referenced Sep 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@go-to-k go-to-k go-to-k approved these changes

@moltar moltar moltar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-cur): Add error handling when CUR is running outside the us-east-1 region
4 participants
@tomoki10 @hoegertn @moltar @go-to-k