[chore][pkg/stanza] Remove reader config #29668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-reader-test-3
branch
2 times, most recently
from
72a328f to
df903ca
Compare
djaglowski
force-pushed
the
pkg-stanza-reader-test-3
branch
from
df903ca to
bf641b2
Compare
djaglowski
changed the title
evan-bradley
approved these changes
Dec 6, 2023
djaglowski
added a commit
that referenced
this pull request
Dec 6, 2023
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
`reader.Config` contained many fields which were only relevant to `reader.Factory`. Once moving these fields to `reader.Factory`, it became apparent that the `reader.Reader` struct only needs access to a few specific fields (`fingerprintSize`, `maxLogSize`, `deleteAtEOF`, `emitFunc`). This also contains some corresponding cleanup of the fields within the factory struct.
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reader.Configcontained many fields which were only relevant toreader.Factory. Once moving these fields toreader.Factory, it became apparent that thereader.Readerstruct only needs access to a few specific fields (fingerprintSize,maxLogSize,deleteAtEOF,emitFunc). This also contains some corresponding cleanup of the fields within the factory struct.