[receiver/sqlquery] fail on missing value for logs, collect errors #35189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
approved these changes
Sep 16, 2024
crobert-1
approved these changes
Sep 17, 2024
crobert-1
added
the
ready to merge
andrzej-stencel
merged commit 507ec47
into
open-telemetry:main
162 of 163 checks passed
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…pen-telemetry#35189) **Description:** * [breaking] Fail if for log column not found in result set (for consistency with metrics behaviour) * Instead of fail-fast, collect all errors that occurred when transforming row to metric or log **Link to tracking Issue:** open-telemetry#35068 **Testing:** Added/updated unit tests **Documentation:** n/a Closes open-telemetry#35068
Grandys
deleted the
sqlquery-fail-on-missing-log-column-collect-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: #35068
Testing: Added/updated unit tests
Documentation: n/a
Closes #35068