Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Skip flaky test on Windows #35302

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Sep 19, 2024

Description:
Since receiver/googlecloudspanner is unmaintained I'm opting to simply skip the flaky test on Windows.

Link to tracking Issue:
Workaround for #32397

Testing:
N/A

Documentation:
N/A

@atoulme atoulme added the Run Windows Enable running windows test on a PR label Sep 19, 2024
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I entirely agree skipping is the right move for now. Slight nit though, I might leave the original issue open in the case of this component finding a maintainer. While we have the component in contrib it makes sense to keep its issues. If we get to the point of removing it we can go through and close all related issues 👍

If that's agreeable, we can remove the Fix prefix before the issue number in the PR description.

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 19, 2024
@crobert-1
Copy link
Member

Another test in the same file failed on Windows:

itemcardinality_test.go:199: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:199
        	Error:      	"[0xc000089800 0xc000089[83](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10946967052/job/30394655819#step:8:84)0 0xc000089860]" should have 4 item(s), but has 3
        	Test:       	TestItemCardinalityFilter_FilterItems

We can add a skip now or later, whatever's easier

@pjanotti
Copy link
Contributor Author

@crobert-1 let me add the skip for TestItemCardinalityFilter_FilterItems now. If others pop up I will feel tempted to use a build tag to skip all tests in Windows.

@codeboten codeboten merged commit 2cc8cea into open-telemetry:main Sep 19, 2024
171 of 172 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 19, 2024
@pjanotti pjanotti deleted the skip-flaky-windows-test-googlecloudspannerreceiver branch September 20, 2024 00:29
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
**Description:**
Since `receiver/googlecloudspanner` is unmaintained I'm opting to simply
skip the flaky test on Windows.

**Link to tracking Issue:**
Workaround for open-telemetry#32397
@manu2
Copy link
Contributor

manu2 commented Dec 3, 2024

Looking into the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/googlecloudspanner Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants