Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Skip flaky test on Windows #35302

Merged
merged 4 commits into from
Sep 19, 2024
Merged

[chore] Skip flaky test on Windows #35302

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08201c1
[chore] Skip flaky test on Windows
pjanotti Sep 19, 2024
b8d5825
Fix import order
pjanotti Sep 19, 2024
2f5109a
Skip another flaky test
pjanotti Sep 19, 2024
66cb530
Merge branch 'main' into skip-flaky-windows-test-googlecloudspannerre…
pjanotti Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package filter

import (
"runtime"
"testing"
"time"

Expand Down Expand Up @@ -122,6 +123,9 @@ func TestItemCardinalityFilter_Shutdown(t *testing.T) {
}

func TestItemCardinalityFilter_Filter(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test on Windows due to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32397")
}
items := initialItems(t)
logger := zaptest.NewLogger(t)
filter, err := NewItemCardinalityFilter(metricName, totalLimit, limitByTimestamp, itemActivityPeriod, logger)
Expand Down Expand Up @@ -175,6 +179,9 @@ func TestItemCardinalityFilter_Filter(t *testing.T) {
}

func TestItemCardinalityFilter_FilterItems(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test on Windows due to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32397")
}
items := initialItemsWithSameTimestamp(t)
logger := zaptest.NewLogger(t)
filter, err := NewItemCardinalityFilter(metricName, totalLimit, limitByTimestamp, itemActivityPeriod, logger)
Expand Down
Loading