Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(otelarrowreceiver): Support disabling admission control #36081

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Oct 29, 2024

Description

Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow receiver for admission control.

Link to tracking issue

Part of #36074.

Testing

Adds a new end-to-end test to verify admission control with/without waiters and unbounded. The test was taken from #36033.

Documentation

Added: "0" request_limit_mib indicates no admission control.

@jmacd jmacd requested a review from a team as a code owner October 29, 2024 22:11
@jmacd jmacd requested a review from andrzej-stencel October 29, 2024 22:11
@github-actions github-actions bot requested a review from moh-osman3 October 29, 2024 22:12
@jmacd jmacd marked this pull request as draft October 30, 2024 15:03
@jmacd jmacd marked this pull request as ready for review October 30, 2024 19:26
@jmacd jmacd force-pushed the jmacd/otlpadmit_zerobound branch from 615d2e9 to 0abd4de Compare October 30, 2024 19:27
Copy link
Contributor

@moh-osman3 moh-osman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrzej-stencel andrzej-stencel merged commit 8f6d236 into open-telemetry:main Oct 31, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2024
ArthurSens pushed a commit to ArthurSens/opentelemetry-collector-contrib that referenced this pull request Nov 4, 2024
…try#36081)

#### Description

Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow
receiver for admission control.

#### Link to tracking issue

Part of open-telemetry#36074.

#### Testing

Adds a new end-to-end test to verify admission control with/without
waiters and unbounded. The test was taken from open-telemetry#36033.

#### Documentation

Added: "0" request_limit_mib indicates no admission control.
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…try#36081)

#### Description

Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow
receiver for admission control.

#### Link to tracking issue

Part of open-telemetry#36074.

#### Testing

Adds a new end-to-end test to verify admission control with/without
waiters and unbounded. The test was taken from open-telemetry#36033.

#### Documentation

Added: "0" request_limit_mib indicates no admission control.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants