-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(otelarrowreceiver): Support disabling admission control #36081
Merged
andrzej-stencel
merged 2 commits into
open-telemetry:main
from
jmacd:jmacd/otlpadmit_zerobound
Oct 31, 2024
Merged
(otelarrowreceiver): Support disabling admission control #36081
andrzej-stencel
merged 2 commits into
open-telemetry:main
from
jmacd:jmacd/otlpadmit_zerobound
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
force-pushed
the
jmacd/otlpadmit_zerobound
branch
from
October 30, 2024 19:27
615d2e9
to
0abd4de
Compare
moh-osman3
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwear
approved these changes
Oct 30, 2024
…tor-contrib into jmacd/otlpadmit_zerobound
andrzej-stencel
approved these changes
Oct 31, 2024
This was referenced Nov 1, 2024
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…try#36081) #### Description Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow receiver for admission control. #### Link to tracking issue Part of open-telemetry#36074. #### Testing Adds a new end-to-end test to verify admission control with/without waiters and unbounded. The test was taken from open-telemetry#36033. #### Documentation Added: "0" request_limit_mib indicates no admission control.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…try#36081) #### Description Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow receiver for admission control. #### Link to tracking issue Part of open-telemetry#36074. #### Testing Adds a new end-to-end test to verify admission control with/without waiters and unbounded. The test was taken from open-telemetry#36033. #### Documentation Added: "0" request_limit_mib indicates no admission control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a no-op implementation of the BoundedQueue used by the OTel-Arrow receiver for admission control.
Link to tracking issue
Part of #36074.
Testing
Adds a new end-to-end test to verify admission control with/without waiters and unbounded. The test was taken from #36033.
Documentation
Added: "0" request_limit_mib indicates no admission control.