[chore] [exporter/signalfx] Rework property/tags update tests #36086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
signalfx-exp-rework-tests
branch
2 times, most recently
from
75021e7 to
fe28fe7
Compare
atoulme
approved these changes
Oct 30, 2024
dmitryax
force-pushed
the
signalfx-exp-rework-tests
branch
from
fe28fe7 to
6255390
Compare
Rework the tests to explicitly control requests handling by the mock server. Use channels to control request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change.
dmitryax
force-pushed
the
signalfx-exp-rework-tests
branch
from
6255390 to
45c1e11
Compare
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…elemetry#36086) Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change. This change also unblocks open-telemetry#36044 which can be covered after this
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…elemetry#36086) Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts. All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change. This change also unblocks open-telemetry#36044 which can be covered after this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the tests to explicitly control requests handling by the mock server. Use channels to control start and finish of request handling instead of relying on timer and timeouts.
All the tests in the package are now executed in 1.5 seconds compared to 19 seconds as before the change.
This change also unblocks #36044 which can be covered after this