Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles support in OTLP Exporter #11131

Closed
wants to merge 22 commits into from
Closed

Profiles support in OTLP Exporter #11131

wants to merge 22 commits into from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 11, 2024 •
edited
Loading

Description

This adds profiles support to the OTLP exporters.
Note: This includes some commits from #11071 that were required in here too.

@dmathieu dmathieu force-pushed the otlpexporter branch 2 times, most recently from da2d91f to 001e190 Compare September 11, 2024 10:07
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.75258% with 24 lines in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (1391fab) to head (713f25d).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
.../exporterhelper/exporterhelperprofiles/profiles.go 91.80% 3 Missing and 2 partials ⚠️
exporter/exporterhelper/internal/obsexporter.go 0.00% 5 Missing ⚠️
exporter/otlphttpexporter/factory.go 76.47% 2 Missing and 2 partials ⚠️
exporter/otlphttpexporter/otlp.go 88.88% 3 Missing and 1 partial ⚠️
...terhelper/exporterhelperprofiles/profiles_batch.go 97.75% 1 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request.go 0.00% 2 Missing ⚠️
exporter/otlpexporter/otlp.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11131      +/-   ##
==========================================
- Coverage   91.79%   91.78%   -0.02%     
==========================================
  Files         422      426       +4     
  Lines       20023    20285     +262     
==========================================
+ Hits        18380    18618     +238     
- Misses       1266     1283      +17     
- Partials      377      384       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review September 11, 2024 11:50
@dmathieu dmathieu requested review from a team and jpkrohling September 11, 2024 11:51
@mx-psi mx-psi added this to the Profiling support milestone Sep 12, 2024
@mx-psi mx-psi mentioned this pull request Sep 12, 2024
Closed
mx-psi
mx-psi reviewed Sep 12, 2024
View reviewed changes
exporter/otlpexporter/README.md Outdated Show resolved Hide resolved
exporter/exporterhelper/profiles.go Outdated Show resolved Hide resolved
@dmathieu dmathieu force-pushed the otlpexporter branch 4 times, most recently from 055a6bb to cb0a2a3 Compare September 12, 2024 13:26
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Sep 19, 2024
@dmathieu @jackgopack4
[chore] split exporterhelper so a separate profiles module can use it (…
4fee34e 
…open-telemetry#11215)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is part of open-telemetry#11131, splitting the exporterhelper module with a new
`internal` submodule that holds everything shared by the signals.
This is so a new `exporterhelperprofiles` module can make use of the
shared structs.
codeboten pushed a commit that referenced this pull request Sep 19, 2024
@mx-psi @dmathieu
[chore][exporter/otlphttpexporter] Generalize composeSignalURL (#11206
1391fab 
)

#### Description

Split off from #11131. Prepares OTLP HTTP exporter for supporting
profiles (which uses `/v1development`)

Co-authored-by: Damien Mathieu <[email protected]>
@dmathieu dmathieu requested a review from a team as a code owner September 20, 2024 07:22
@dmathieu dmathieu force-pushed the otlpexporter branch 3 times, most recently from bd6d2cd to d27e777 Compare September 20, 2024 07:45
This was referenced Sep 20, 2024
Merged
Merged
dmathieu added a commit to dmathieu/opentelemetry-collector that referenced this pull request Sep 20, 2024
@mx-psi @dmathieu
[consumer] Add new consumererrorprofiles module
4e9417e 
This was authored by @dmathieu on PR open-telemetry#11131

Co-authored-by: Damien Mathieu <[email protected]>
mx-psi pushed a commit that referenced this pull request Sep 20, 2024
@dmathieu
Introduce SampleCount to ProfilesSink (#11225)
18e4b49 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is an extraction from
#11131.

cc @mx-psi
dmathieu added a commit to dmathieu/opentelemetry-collector that referenced this pull request Sep 20, 2024
@mx-psi @dmathieu
[consumer] Add new consumererrorprofiles module
26fad12 
This was authored by @dmathieu on PR open-telemetry#11131

Co-authored-by: Damien Mathieu <[email protected]>
mx-psi pushed a commit that referenced this pull request Oct 4, 2024
@julianocosta89
[chore]: Add Profiles Marshaler to otlptext (#11161)
13951af 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards #11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR #11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 5, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
@julianocosta89 @jackgopack4
[chore]: Add Profiles Marshaler to otlptext (open-telemetry#11161)
1283000 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards open-telemetry#11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR open-telemetry#11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
mx-psi added a commit that referenced this pull request Oct 9, 2024
@mx-psi @dmathieu
[consumer] Add new consumererrorprofiles module (#11207)
5ac1607 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Split off from #11131. Adds new module for consumer errors for profiles.

---------

Co-authored-by: Damien Mathieu <[email protected]>
@mx-psi
Copy link
Member

mx-psi commented Oct 9, 2024

@dmathieu Can you fix the merge conflicts?

@dmathieu
Copy link
Member Author

Closing this PR, as everything it contains has been split into multiple smaller ones.

@dmathieu dmathieu closed this Oct 15, 2024
@dmathieu dmathieu deleted the otlpexporter branch October 15, 2024 09:23
mx-psi added a commit that referenced this pull request Oct 16, 2024
@dmathieu @mx-psi
[chore] add exporterhelperprofiles package (#11226)
388bae7 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from #11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires #11207✅  and #11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
@dmathieu @mx-psi @djaglowski
[chore] add exporterhelperprofiles package (open-telemetry#11226)
35d5c06 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@mx-psi @dmathieu @HongChenTW
[chore][exporter/otlphttpexporter] Generalize composeSignalURL (ope…
dae37e5 
…n-telemetry#11206)

#### Description

Split off from open-telemetry#11131. Prepares OTLP HTTP exporter for supporting
profiles (which uses `/v1development`)

Co-authored-by: Damien Mathieu <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@dmathieu @HongChenTW
Introduce SampleCount to ProfilesSink (open-telemetry#11225)
9429f3c 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is an extraction from
open-telemetry#11131.

cc @mx-psi
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@julianocosta89 @HongChenTW
[chore]: Add Profiles Marshaler to otlptext (open-telemetry#11161)
6c32a5b 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This is the initial work towards open-telemetry#11155.
This PR adds profiles marshalers to `otlptext`, which will be used in
the `debugexporter` later on.

To continue the work on the `debugexporter` I'd wait on the PR open-telemetry#11131,
as it adds some shared components.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added `TestProfilesText`, testing the following scenarios: 
- `empty_profiles`
- `two_profiles`
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@mx-psi @dmathieu @HongChenTW
[consumer] Add new consumererrorprofiles module (open-telemetry#11207)
a1b324e 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Split off from open-telemetry#11131. Adds new module for consumer errors for profiles.

---------

Co-authored-by: Damien Mathieu <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
@dmathieu @mx-psi @HongChenTW
[chore] add exporterhelperprofiles package (open-telemetry#11226)
1f3af43 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is extracted from open-telemetry#11131.
It adds profiles support for the epxorterhelper, so both the otlp and
otlphttp exporters can support that signal.

It requires open-telemetry#11207✅  and open-telemetry#11225✅  to be merged first.

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Profiling support
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @mx-psi