Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move metrics initialization in service/telemetry #11185

Merged
merged 1 commit into from
Sep 17, 2024

[chore] Move metrics initialization in service/telemetry

ae7b9cb
Select commit
Loading
Failed to load commit list.
Merged

[chore] Move metrics initialization in service/telemetry #11185

[chore] Move metrics initialization in service/telemetry
ae7b9cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 0s

91.88% (target 90.00%)

View this Pull Request on Codecov

91.88% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (1339c01) to head (ae7b9cb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
service/internal/promtest/server_util.go 71.42% 2 Missing and 2 partials ⚠️
service/service.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11185      +/-   ##
==========================================
+ Coverage   91.86%   91.88%   +0.02%     
==========================================
  Files         413      416       +3     
  Lines       19766    19864      +98     
==========================================
+ Hits        18158    18252      +94     
+ Misses       1239     1236       -3     
- Partials      369      376       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.