Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ: Specify how to populate messaging.destination.name #1531

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d9574a8
Specify destination name for RabbitMQ
joaopgrassi Oct 30, 2024
6efe0b3
Add changelog
joaopgrassi Oct 30, 2024
b02ff2a
Add queue to destination name
joaopgrassi Oct 31, 2024
29209ae
Lint
joaopgrassi Oct 31, 2024
52f57bb
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 4, 2024
9fdf75d
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 5, 2024
f953d89
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 7, 2024
42768c9
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 8, 2024
8567f58
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 8, 2024
70bdbdf
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 8, 2024
0598254
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 13, 2024
cbab7c9
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Nov 29, 2024
69b8141
simply and remove queue from dest name
joaopgrassi Nov 29, 2024
47dc2c0
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 10, 2024
ca4034f
rollback
joaopgrassi Dec 10, 2024
210cea0
PR suggestions
joaopgrassi Dec 12, 2024
275e760
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 12, 2024
c87df8f
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 13, 2024
f48427f
Add guidance on yaml file
joaopgrassi Dec 13, 2024
839f0cb
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 16, 2024
bde99d0
make destination name required for rabbitmq and remove batching case
joaopgrassi Dec 16, 2024
0eb8b2f
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 17, 2024
b6bbc85
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 17, 2024
40c1410
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 18, 2024
d537c6d
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 19, 2024
568f90c
Pr suggestions
joaopgrassi Dec 27, 2024
b668ff2
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 27, 2024
359cf02
fix typo
joaopgrassi Dec 27, 2024
7000965
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi Dec 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .chloggen/rabbitmq-destination-name.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
change_type: breaking
component: messaging
note: "RabbitMQ: Specify how to populate `messaging.destination.name`"
issues: [1529]
22 changes: 20 additions & 2 deletions docs/messaging/rabbitmq.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,26 @@ The Semantic Conventions for [RabbitMQ](https://www.rabbitmq.com/) extend and ov

## RabbitMQ attributes

In RabbitMQ, the destination is defined by an *exchange* and a *routing key*.
`messaging.destination.name` MUST be set to the name of the exchange. This will be an empty string if the default exchange is used.
### Destination name

n RabbitMQ, the destination is defined by an *exchange*, a *routing key* and
for consumers, a *queue*.

`messaging.destination.name` MUST be set to:
joaopgrassi marked this conversation as resolved.
Show resolved Hide resolved

#### Producers

- `{exchange}:{routing key}` when both values are present and non-empty.
joaopgrassi marked this conversation as resolved.
Show resolved Hide resolved
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted.
- Otherwise: `amq.default`
joaopgrassi marked this conversation as resolved.
Show resolved Hide resolved

#### Consumers

- `{exchange}:{routing key}:{queue}` when all values are present and non-empty.
joaopgrassi marked this conversation as resolved.
Show resolved Hide resolved
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted.

For cases when `{routing key}` and `{queue}` are equal, only one of them SHOULD
be used, e.g., `{exchange}:{routing key}`.

<!-- semconv messaging.rabbitmq -->
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
Expand Down
Loading