Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ: Specify how to populate
messaging.destination.name
#1531base: main
Are you sure you want to change the base?
RabbitMQ: Specify how to populate
messaging.destination.name
#1531Changes from 19 commits
d9574a8
6efe0b3
b02ff2a
29209ae
52f57bb
9fdf75d
f953d89
42768c9
8567f58
70bdbdf
0598254
cbab7c9
69b8141
47dc2c0
ca4034f
210cea0
275e760
c87df8f
f48427f
839f0cb
bde99d0
0eb8b2f
b6bbc85
40c1410
d537c6d
568f90c
b668ff2
359cf02
7000965
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be an
{exchange}
but not a{routing key}
, or can there be a{routing key}
but not a{exchange}
? it may be helpful to be explicit about fallback options (if any), in particular, do you drop the:
or not when only one of them is present, here's an example where we cover these fallbacks: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md#nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they can be empty like that AFAIK. I adapted it a bit, hopefully it is clearer now.