-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adios2 warn groupbased encoding #1498
Adios2 warn groupbased encoding #1498
Conversation
@franzpoeschel ready for rebase :) |
09f3077
to
97d2d7d
Compare
@ax3l You recently mentioned a workflow that you have where you repeatedly close and reopen an Iteration to write data to it. Since this workflow implies that you cannot use variable-based encoding, I assume that you use file-based encoding instead? |
97d2d7d
to
ad5b6b7
Compare
I would like to adapt all examples and tests to this change. Since this requires more features for file-based enconding (e.g. reopening a closed iteration) and for variable-based encoding (e.g. random-access) alike, I will postpone this PR for now. |
ad5b6b7
to
2a321f3
Compare
185b37f
to
88cc81f
Compare
d89e566
to
6e68d77
Compare
6e68d77
to
d868b27
Compare
This uncovered loads of bugs
d868b27
to
93ca7a7
Compare
Should not go into 0.15 release cycle since it advises to use variable-based encoding
Add some environment variable or similar to deactivate thisThe warning is now only printed for the new ADIOS2 encoding (group table), so this does not affect legacy workflowsMaybe adapt testsPostponed to when variable-based encoding becomes more usefulEDIT:
adios2.usesteps
option is now removed, is automatically used ifWriteIterations
is used in the frontendMore context: #1457
The warning is printed only when using the (currently opt-in) group table feature, for the sake of a smoother transition for users.
We should soon make group tables opt-out. A good time would be when we have better support for variable-based encoding.
Breaking because: It's no longer possible to open ADIOS2 group-based files with linear access mode if they don't use the group table feature.