Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --plot-to-board to plot command #184

Closed
wants to merge 5 commits into from

Conversation

Ronaq13
Copy link
Contributor

@Ronaq13 Ronaq13 commented Mar 1, 2018

This flag of plot command will send the plotted burndown chart to the first
card of the Done column.

close #134

@Ronaq13 Ronaq13 force-pushed the adding_plot-to-board_in_plot branch from e7f901e to 8ec340c Compare March 1, 2018 18:30
This flag of plot command will send the plotted burndown chart to the first
card of the `Done` column.

close openSUSE#134
if options[:plot_to_board]
begin
chart = BurndownChart.new @@settings
chart.update(options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also modifying the yml file, which we don't want to modify here. We only want to print the image and push it to the card.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help identifying the line at which it modifying the .yml file. And by .yml file do you mean burndown-data-01.yml file which is created at time of initialization

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inside of the update method.

Yes, the burndown-data-i.yaml file, where i is the number of the sprint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ana06 I dont see any change in the yml file. Please check now is it good to merge?

matheussbernardo and others added 4 commits April 4, 2018 14:02
Added the 'to' statement for the corresponding 'expect' statement
in the unit test of checking the file presence.

close openSUSE#178
Trollolo accepts a definition of custom doing columns in the
burndown YAML file. This used to be part of the `not_done_columns`
setting. This has been split up into `todo_columns` and
`doing_columns`.

Old configurations which use the `not_done_columns` setting will
have to be adjusted. There should be an error message now
explaining what to do.

This fixes a bug where custom doing columns where not properly
accounted for when creating burndown data.
@Ana06
Copy link
Member

Ana06 commented Aug 2, 2018

@Ronaq13 @matheussbernardo @cornelius where are those commits coming from?

@Ana06
Copy link
Member

Ana06 commented Oct 6, 2018

@Ronaq13 what is the state of this PR? 🤔

@Ana06
Copy link
Member

Ana06 commented Oct 23, 2018

Closing due to inactivity, @Ronaq13 feel free to reopen it if you continue working on it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --plot-to-board to plot command
4 participants