Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline-cntr-guide #961

Merged
merged 34 commits into from
Dec 7, 2023
Merged

Pipeline-cntr-guide #961

merged 34 commits into from
Dec 7, 2023

Conversation

rszarecki
Copy link
Contributor

The documentation discussing semantics and usability of Intgrated Circuit pipelein aggregate drop counters

@rszarecki rszarecki requested a review from a team as a code owner September 19, 2023 15:07
@OpenConfigBot
Copy link

OpenConfigBot commented Sep 19, 2023 •
edited
Loading

No major YANG version changes in commit 34eb667

@OpenConfigBot
Copy link

OpenConfigBot commented Sep 19, 2023 •
edited
Loading

Compatibility Report for commit aae0c40:
✅ pyangbind@1c7990f

@dplore dplore self-assigned this Sep 26, 2023
dplore
dplore requested changes Sep 27, 2023
View reviewed changes
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
@dplore dplore mentioned this pull request Sep 28, 2023
Merged
dplore
dplore requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several grammar changes and one or two clarifications suggested.

I also have one functional comment regarding queue drop vs. congestion drop to be considered.

doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
rszarecki and others added 12 commits October 8, 2023 08:19
@rszarecki @dplore
Update Integrated-Circuit_pipeline_ggregated_counters_guide.md
f31bd43 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
c40dbf0 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
044334c 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
20127a0 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
9e0ffbf 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
cacfddc 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
466adc5 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
2b72308 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
99540b0 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
a220ef1 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
8c4747e 
Co-authored-by: Darren Loher <[email protected]>
@rszarecki @dplore
Update openconfig-platform-pipeline-counters.yang
cc0d004 
Co-authored-by: Darren Loher <[email protected]>
rszarecki
rszarecki commented Oct 8, 2023
View reviewed changes
Copy link
Contributor Author

@rszarecki rszarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ptal

@rszarecki rszarecki requested a review from dplore October 9, 2023 01:40
dplore
dplore requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small typo and I think it is good

release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
rolandphung
rolandphung reviewed Nov 8, 2023
View reviewed changes
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the filename, an a is missing in the aggregated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
release/models/platform/openconfig-platform-pipeline-counters.yang Outdated Show resolved Hide resolved
@dplore
Copy link
Member

dplore commented Dec 5, 2023

@rszarecki friendly ping to address the minor comments above, then we can merge this. It is a helpful guide and would like to have it be part of our formal documentation.

rszarecki and others added 9 commits December 5, 2023 16:54
@rszarecki @dplore
Update release/models/platform/openconfig-platform-pipeline-counters.…
043cad1 
…yang

Co-authored-by: Darren Loher <[email protected]>
@rszarecki @rolandphung
Update release/models/platform/openconfig-platform-pipeline-counters.…
eae0894 
…yang

Co-authored-by: Roland Phung <[email protected]>
@rszarecki @rolandphung
Update release/models/platform/openconfig-platform-pipeline-counters.…
d53055b 
…yang

Co-authored-by: Roland Phung <[email protected]>
@rszarecki @rolandphung
Update doc/Integrated-Circuit_pipeline_ggregated_counters_guide.md
963320d 
Co-authored-by: Roland Phung <[email protected]>
@rszarecki @rolandphung
Update release/models/platform/openconfig-platform-pipeline-counters.…
1eafd3a 
…yang

Co-authored-by: Roland Phung <[email protected]>
@rszarecki @rolandphung
Update release/models/platform/openconfig-platform-pipeline-counters.…
aae0c40 
…yang

Co-authored-by: Roland Phung <[email protected]>
@rszarecki
Merge branch 'master' into pipeline-cntr-guide
9ade375
@rszarecki @rolandphung
Update release/models/platform/openconfig-platform-pipeline-counters.…
48403ab 
…yang

Co-authored-by: Roland Phung <[email protected]>
@rszarecki
Rename Integrated-Circuit_pipeline_ggregated_counters_guide.md to Int…
34eb667 
…egrated-Circuit_pipeline_aggregated_counters_guide.md
@rszarecki
Copy link
Contributor Author

@rszarecki friendly ping to address the minor comments above, then we can merge this. It is a helpful guide and would like to have it be part of our formal documentation.

DONE

@dplore dplore merged commit 4e15058 into openconfig:master Dec 7, 2023
5 checks passed
romeyod pushed a commit to romeyod/aftNextHop that referenced this pull request Sep 19, 2024
@rszarecki @dplore
@rolandphung @romeyod
Pipeline-cntr-guide (openconfig#961)
0cdd65b 
* Create Integrated-Circuit_pipeline_ggregated_counters_guide.md

---------

Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Roland Phung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandphung rolandphung rolandphung left review comments

@dplore dplore dplore approved these changes

Assignees

@dplore dplore

Labels
non-breaking
Projects
OC Operator Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rszarecki @OpenConfigBot @dplore @rolandphung